Sync 5.0.0 with main Part 3 #8552
Conversation
Co-authored-by: Riley Karson <[email protected]>
* Add optional_components to documentation * Fix formatting, remove redundant optional * Clean up properties documentation * Apply suggestions from code review Co-authored-by: Stephen Lewis (Burrows) <[email protected]> * Add asterisks --------- Co-authored-by: Stephen Lewis (Burrows) <[email protected]>
* Add comments, link to TeamCity Kotlin DSL docs * Change default value of environment from "public" to "default" This is because Google provider has no public TeamCity resources * Enable different default cron values for `ga`/`beta` downstreams * Enable non-default cron values to be used, based on value of `environment` parameter in TeamCity * Add ability to make VCS root and nightly trigger use non-main branch * Update tests to reflect how entrypoint func requires `branch` parameter now * Update `MAJOR_RELEASE_TESTING` value, and update code to handle unsupported chars * Update `uniqueID` method to uppercase the environment value
* fix enforce_on_key_configs * add updatemask --------- Co-authored-by: Edward Sun <[email protected]>
* chore: replace tgc compare library to go-cmp * convert indent to tab * fix import
* Writing yaml Writing Succeeding Writing real yamls Refactor Refactor Stop reading output Update Remove extra puts, resource to_yaml method Spaces --> tabs Remove * Remove debugging * Spaces * Test * PR feedback, add rspec test Remove spec from folder * PR feedback, rename openapi_generate * Add comment
* Move function serviceAccountCanonicalEmail * Move provider tests * accessapproval tetss * Move activedirectory_test, appengine_test, bigquery_test, bigquerydatatransfer_test, bigtable_test * Move composer_test, cloudtasks_test, cloudrun_test, cloudiot_test, cloudids_test * Move compute_test * Move firestore_test * Move redis_test * Move storagetransfer_test * Fix errors * Move vpcaccess_test * Move apigee_test * Put function to test_utils.go to not break tgc * Remove spaces * Move resource_endpoints_service_test.go back to the google package * Fix rebasing errors
* Writing yaml Writing Succeeding Writing real yamls Refactor Refactor Stop reading output Update Remove extra puts, resource to_yaml method Spaces --> tabs Remove * Remove debugging * Spaces * Test * PR feedback, add rspec test Remove spec from folder * PR feedback, rename openapi_generate * Add comment * Attempt * Add async initialize defaults * Rubocop * Autofix rubocop
…a package for now (#8423)
* Adding custom_audiences field for cloud run v2 service. * Add custom audiences example for Cloud Run v2 API
* tgc: update test data to beta * fix integration test
Started failing consistently recently. Fixes hashicorp/terraform-provider-google#15252
* making sure swp can be created without scope and certificateUrls
* add net_admin field to container cluster for autopilot clusters * add allow_net_admin tests * tweak param name * fix net_admin test format string * fix syntax bug * fix api field typo * version safety and ImportStateVerifyIgnore for min_master_version in test * comment change * Add documentation and remove provider-side validation * add update test
* add depends_on * change depends_on value
* Merge run provider tests and use built provider * Add aliases, fix link * Apply suggestions from code review Co-authored-by: Stephen Lewis (Burrows) <[email protected]> * Move hint and link to wiki * Reorganize into tabs * Apply suggestions from code review Co-authored-by: Stephen Lewis (Burrows) <[email protected]> * Apply suggestions from code review Co-authored-by: Stephen Lewis (Burrows) <[email protected]> * Apply suggestions from code review Co-authored-by: Stephen Lewis (Burrows) <[email protected]> * Add tabs for provider version * Fix link * Apply suggestions from code review Co-authored-by: Stephen Lewis (Burrows) <[email protected]> * Move delve into tabs * Fix ref links * Apply suggestions from code review Co-authored-by: Stephen Lewis (Burrows) <[email protected]> * Apply suggestions from code review * Apply suggestions from code review Co-authored-by: Stephen Lewis (Burrows) <[email protected]> --------- Co-authored-by: Stephen Lewis (Burrows) <[email protected]>
* Use module tpg in go.mod * Remove comment
#8406) * Properly handle ABP midnight (hours = 0) * Add ExpectNonEmptyPlan to test * Add continuous backup config to alloydb cluster * add more unit tests * Adding more tests * Fix cluster.yaml lint * Add default value and update cmek test * Update test to use kms key bootstrapping util * condense update tests * Change encryptionType output field to string * use two different keys * Only update encryption in CBR
… notification configs. (#8507) * Add support for setting `sendPreviousResourceOnDelete` for FHIR store notification configs. * Add test for sendPreviousResourceOnDelete
) * adding both resources, basic test for serviceClass it's working, need to fix the test scenario for policy * fix the test scenario and the service class resource properties * adding a testing update, just adding the labels for the resource * added the resource service connection map, and it's basic test, need to evaluate * Revert "added the resource service connection map, and it's basic test, need to evaluate" This reverts commit 4240e1d. * removing the service class in one test scenario and using a static value * fix a typo * removing serviceClass and fix the tests * removing ga tag and updatinga etag for fingerprint type * updating the code, to remove the static value from the docs, need to test * adding a file to tpgtools override at product level * adding function to help with env var, but the patch on tests it's failing * adding the variable to be used in the docs * fixing the test, the network field cannot be immutable * removing the env_var service class and adding a static value * updating the value used from tests and documentation * removing unused resources for docs and tests * fix typos, not used variables and run the fmt * adding description to the basic test * fixed yaml variable override * removing unused resources for tests, and making the test fails with network as immutable * adding encoder to help network field be immutable and be sent on patch method
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Breaking Change(s) DetectedThe following breaking change(s) were detected within your pull request.
If you believe this detection to be incorrect please raise the concern with your reviewer. If you intend to make this change you will need to wait for a major release window. An Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 191 files changed, 12798 insertions(+), 1751 deletions(-)) Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_cloud_run_v2_service" "primary" {
custom_audiences = # value needed
}
Resource: resource "google_compute_instance_from_machine_image" "primary" {
network_interface {
ipv6_access_config {
name = # value needed
}
}
}
Resource: resource "google_compute_instance_from_template" "primary" {
network_interface {
ipv6_access_config {
name = # value needed
}
}
}
Resource: resource "google_container_cluster" "primary" {
allow_net_admin = # value needed
node_pool {
network_config {
additional_node_network_configs {
network = # value needed
subnetwork = # value needed
}
additional_pod_network_configs {
max_pods_per_node = # value needed
secondary_pod_range = # value needed
subnetwork = # value needed
}
}
node_config {
host_maintenance_policy {
maintenance_interval = # value needed
}
}
}
}
Resource: resource "google_container_node_pool" "primary" {
network_config {
additional_pod_network_configs {
max_pods_per_node = # value needed
secondary_pod_range = # value needed
subnetwork = # value needed
}
}
}
Resource: resource "google_monitoring_alert_policy" "primary" {
conditions {
condition_prometheus_query_language {
alert_rule = # value needed
duration = # value needed
evaluation_interval = # value needed
labels = # value needed
query = # value needed
rule_group = # value needed
}
}
}
|
Tests analyticsTotal tests: Action takenFound 114 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccBigqueryDataTransferConfig|TestAccMonitoringAlertPolicy|TestAccNetworkServicesGateway_minimalSwp|TestAccWorkstationsWorkstationConfig_workstationConfigAcceleratorsExample|TestAccVPCAccessConnector_vpcAccessConnectorThroughput|TestAccVPCAccessConnector_vpcAccessConnectorExample|TestAccVPCAccessConnector_vpcAccessConnectorSharedVpcExample|TestAccMonitoringMonitoredProject_projectNumShortForm|TestAccMonitoringMonitoredProject_projectNumLongForm|TestAccNetworkConnectivityServiceConnectionPolicy_networkConnectivityPolicyBasicExample|TestAccNetworkConnectivityServiceConnectionPolicy_update|TestAccMonitoringUptimeCheckConfig_changeNonUpdatableFields|TestAccMonitoringUptimeCheckConfig_update|TestAccMonitoringUptimeCheckConfig_jsonPathUpdate|TestAccLookerInstance_lookerInstanceEnterpriseFullExample|TestAccVPCAccessConnectorDatasource_basic|TestAccHealthcareFhirStore_basic|TestAccHealthcareFhirStore_healthcareFhirStoreNotificationConfigsExample|TestAccHealthcareFhirStore_healthcareFhirStoreStreamingConfigExample|TestAccDocumentAIWarehouseLocation_documentAiWarehouseLocationExample|TestAccDocumentAIWarehouseDocumentSchema_documentAiWarehouseDocumentSchemaTimestampExample|TestAccDocumentAIWarehouseDocumentSchema_documentAiWarehouseDocumentSchemaDatetimeExample|TestAccDocumentAIWarehouseDocumentSchema_documentAiWarehouseDocumentSchemaMapExample|TestAccDocumentAIWarehouseDocumentSchema_documentAiWarehouseDocumentSchemaEnumExample|TestAccDocumentAIWarehouseDocumentSchema_documentAiWarehouseDocumentSchemaPropertyEnumExample|TestAccDocumentAIWarehouseDocumentSchema_documentAiWarehouseDocumentSchemaPropertyExample|TestAccDocumentAIWarehouseDocumentSchema_documentAiWarehouseDocumentSchemaFloatExample|TestAccContainerCluster_withPrivateClusterConfigGlobalAccessEnabledOnly|TestAccDocumentAIWarehouseDocumentSchema_documentAiWarehouseDocumentSchemaIntegerExample|TestAccDocumentAIWarehouseDocumentSchema_documentAiWarehouseDocumentSchemaTextExample|TestAccContainerCluster_customPlacementPolicy|TestAccComputeSecurityPolicy_update|TestAccDatabaseMigrationServiceConnectionProfile_databaseMigrationServiceConnectionProfileAlloydbExample|TestAccComputeSecurityPolicy_withPreconfiguredWafConfig|TestAccContainerCluster_withEnablePrivateEndpointToggle|TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupPscServiceAttachmentExample|TestAccContainerCluster_autopilot_net_admin|TestAccContainerNodePool_withHostMaintenancePolicy|TestAccContainerNodePool_customPlacementPolicy|TestAccContainerCluster_withEnableKubernetesBetaAPIsOnExistingCluster|TestAccContainerCluster_withEnableKubernetesBetaAPIs|TestAccSpannerDatabase_enableDropProtection|TestAccContainerCluster_withMultiNetworking|TestAccComputeInstance_ipv6ExternalReservation|TestAccComputeRegionInstanceTemplate_localSsdRecoveryTimeout|TestAccSpannerDatabase_basic|TestAccComputeServiceAttachment_serviceAttachmentBasicExampleUpdate|TestAccComputeServiceAttachment_serviceAttachmentExplicitProjectsExample|TestAccComputeServiceAttachment_serviceAttachmentBasicExample|TestAccComputeInstanceFromTemplateWithOverride_localSsdRecoveryTimeout|TestAccComputeSecurityPolicy_withRedirectOptionsUpdate|TestAccComputeSecurityPolicy_withHeadAction|TestAccComputeServiceAttachment_serviceAttachmentReconcileConnectionsExample|TestAccComputeInstanceTemplate_localSsdRecoveryTimeout|TestAccComputeSecurityPolicy_EnforceOnKeyUpdates|TestAccComputeInstanceFromTemplate_localSsdRecoveryTimeout|TestAccComputeInstance_localSsdRecoveryTimeout_update|TestAccComputeInstanceFromMachineImage_localSsdRecoveryTimeout|TestAccComputeRegionBackendService_regionBackendServiceConnectionTrackingExample|TestAccPubsubSubscription_pushNoWrapper|TestAccComputeInstanceFromMachineImageWithOverride_localSsdRecoveryTimeout|TestAccContainerNodePool_withMultiNicNetworkConfig|TestAccComputeInstance_localSsdRecoveryTimeout|TestAccComputeDisk_multiWriter|TestAccCloudBuildTrigger_cloudbuildTriggerPubsubConfigExample|TestAccComputeForwardingRule_forwardingRuleVpcPscExampleUpdate|TestAccCloudbuildWorkerPool_withNetwork|TestAccCloudBuildTrigger_cloudbuildTriggerWebhookConfigExample|TestAccCloudIdsEndpoint_basic|TestAccCloudBuildTrigger_cloudbuildTriggerManualExample|TestAccCloudRunV2Job_cloudrunv2JobVpcaccessExample|TestAccCloudRunV2Service_cloudrunv2ServiceFullUpdate|TestAccCloudRunService_cloudRunServiceCreateHasStatus|TestAccCloudFunctionsFunction_vpcConnector|TestAccCloudBuildTrigger_cloudbuildTriggerPubsubWithRepoExample|TestAccAppEngineFirewallRule_appEngineFirewallRuleBasicExample|TestAccAlloydbInstance_update|TestAccComputeForwardingRule_forwardingRuleVpcPscNoAutomateDnsExample|TestAccAlloydbCluster_continuousBackup_CMEKIsUpdatable|TestAccComputeForwardingRule_forwardingRuleVpcPscExample|TestAccAlloydbInstance_alloydbInstanceBasicExample|TestAccAlloydbCluster_continuousBackup_update|TestAccAppEngineApplication_withIAP|TestAccCloudBuildTrigger_cloudbuildTriggerBitbucketServerPullRequestExample|TestAccAlloydbCluster_continuousBackup_noChangeIfRemoved|TestAccAppEngineApplication_basic|TestAccCloudBuildTrigger_cloudbuildTriggerBitbucketServerPushExample|TestAccAlloydbCluster_continuousBackup_update_noChangeIfDefaultsSet|TestAccAlloydbCluster_continuousBackup_enabledByDefault|TestAccCloudRunV2Job_cloudrunv2JobFullUpdate|TestAccAlloydbBackup_createBackupWithMandatoryFields|TestAccCloudBuildTrigger_cloudbuildTriggerRepoExample|TestAccIapWebTypeAppEngineIamMemberGenerated_withCondition|TestAccIapWebTypeAppEngineIamBindingGenerated_withCondition|TestAccIapWebTypeAppEngineIamPolicyGenerated|TestAccIapWebRegionBackendServiceIamBindingGenerated_withCondition|TestAccIapWebRegionBackendServiceIamPolicyGenerated|TestAccIapWebTypeAppEngineIamBindingGenerated|TestAccIapWebRegionBackendServiceIamMemberGenerated|TestAccIapWebRegionBackendServiceIamPolicyGenerated_withCondition|TestAccIapWebRegionBackendServiceIamBindingGenerated|TestAccAlloydbInstance_updateDatabaseFlagInPrimaryInstance|TestAccAppEngineStandardAppVersion_update|TestAccIapWebRegionBackendServiceIamMemberGenerated_withCondition|TestAccAlloydbInstance_createPrimaryAndReadPoolInstance|TestAccAlloydbInstance_createInstanceWithMandatoryFields|TestAccAlloydbCluster_maximumFields|TestAccAlloydbInstance_createInstanceWithMaximumFields|TestAccIapWebTypeAppEngineIamMemberGenerated|TestAccAlloydbCluster_AutomatedBackupPolicyHandlesMidnight|TestAccAlloydbCluster_alloydbClusterFullExample|TestAccCloudRunV2Service_cloudrunv2ServiceVpcaccessExample|TestAccIapWebTypeAppEngineIamPolicyGenerated_withCondition|TestAccAlloydbCluster_update |
|
Rerun these tests in REPLAYING mode to catch issues
|
|
/gcbrun |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Breaking Change(s) DetectedThe following breaking change(s) were detected within your pull request.
If you believe this detection to be incorrect please raise the concern with your reviewer. If you intend to make this change you will need to wait for a major release window. An Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 191 files changed, 12798 insertions(+), 1751 deletions(-)) Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_cloud_run_v2_service" "primary" {
custom_audiences = # value needed
}
Resource: resource "google_compute_instance_from_machine_image" "primary" {
network_interface {
ipv6_access_config {
name = # value needed
}
}
}
Resource: resource "google_compute_instance_from_template" "primary" {
network_interface {
ipv6_access_config {
name = # value needed
}
}
}
Resource: resource "google_container_cluster" "primary" {
allow_net_admin = # value needed
node_pool {
network_config {
additional_node_network_configs {
network = # value needed
subnetwork = # value needed
}
additional_pod_network_configs {
max_pods_per_node = # value needed
secondary_pod_range = # value needed
subnetwork = # value needed
}
}
node_config {
host_maintenance_policy {
maintenance_interval = # value needed
}
}
}
}
Resource: resource "google_container_node_pool" "primary" {
network_config {
additional_pod_network_configs {
max_pods_per_node = # value needed
secondary_pod_range = # value needed
subnetwork = # value needed
}
}
}
Resource: resource "google_monitoring_alert_policy" "primary" {
conditions {
condition_prometheus_query_language {
alert_rule = # value needed
duration = # value needed
evaluation_interval = # value needed
labels = # value needed
query = # value needed
rule_group = # value needed
}
}
}
|
Tests analyticsTotal tests: Action takenFound 11 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccVPCAccessConnectorDatasource_basic|TestAccDatabaseMigrationServiceConnectionProfile_databaseMigrationServiceConnectionProfileAlloydbExample|TestAccCloudIdsEndpoint_basic|TestAccCloudbuildWorkerPool_withNetwork|TestAccAlloydbInstance_updateDatabaseFlagInPrimaryInstance|TestAccAlloydbInstance_createPrimaryAndReadPoolInstance|TestAccAlloydbInstance_createInstanceWithMaximumFields|TestAccAlloydbBackup_createBackupWithMandatoryFields|TestAccAlloydbInstance_createInstanceWithMandatoryFields|TestAccAlloydbInstance_update|TestAccAlloydbInstance_alloydbInstanceBasicExample |
|
Rerun these tests in REPLAYING mode to catch issues
|
shuyama1
added
the
override-breaking-change
|
/gcbrun |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Breaking Change(s) DetectedThe following breaking change(s) were detected within your pull request.
If you believe this detection to be incorrect please raise the concern with your reviewer. If you intend to make this change you will need to wait for a major release window. An Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 191 files changed, 12798 insertions(+), 1751 deletions(-)) Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_cloud_run_v2_service" "primary" {
custom_audiences = # value needed
}
Resource: resource "google_compute_instance_from_machine_image" "primary" {
network_interface {
ipv6_access_config {
name = # value needed
}
}
}
Resource: resource "google_compute_instance_from_template" "primary" {
network_interface {
ipv6_access_config {
name = # value needed
}
}
}
Resource: resource "google_container_cluster" "primary" {
allow_net_admin = # value needed
node_pool {
network_config {
additional_node_network_configs {
network = # value needed
subnetwork = # value needed
}
additional_pod_network_configs {
max_pods_per_node = # value needed
secondary_pod_range = # value needed
subnetwork = # value needed
}
}
node_config {
host_maintenance_policy {
maintenance_interval = # value needed
}
}
}
}
Resource: resource "google_container_node_pool" "primary" {
network_config {
additional_pod_network_configs {
max_pods_per_node = # value needed
secondary_pod_range = # value needed
subnetwork = # value needed
}
}
}
Resource: resource "google_monitoring_alert_policy" "primary" {
conditions {
condition_prometheus_query_language {
alert_rule = # value needed
duration = # value needed
evaluation_interval = # value needed
labels = # value needed
query = # value needed
rule_group = # value needed
}
}
}
|
Tests analyticsTotal tests:
|
|
For tests failed in #8552 (comment). I think they are related to the recent cleanup of tenant resources b/293326201. Some tests start to fail for pre-existing bootstrapped networks. So I just copied the cassettes over from main as the tests passed #8473 which was before the cleanup in VCR projects. Plus, I just checked our nightly and these tests passed in both ga and beta projects (some other tests failed with the same issue though). I'm reaching out to the service team and see if it can be resolved. Or simply renaming the pre-existing bootstrapped networks should also fix the problem. Either way, I'll create a fix against the main branch. So I just copied the cassettes over for now to avoid these tests failed for future 5.0.0 PRs |
|
No merge conflicts for this one, but it's probably because we only have two changes merged to the 5.0 |
shuyama1
merged commit f3460af
into
FEATURE-BRANCH-major-release-5.0.0
If this PR is for Terraform, I acknowledge that I have:
make testandmake lintin the generated providers to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)