Use timezone aware datetimes #6587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
samples
google-cla
bot
added
the
cla: yes
busunkim96
requested review from
gcseh,
leahecole,
rachael-ds and
a team
as code owners
dandhlee
approved these changes
Aug 24, 2021
dandhlee
reviewed
Aug 24, 2021
shubha-rajan
approved these changes
Oct 19, 2021
frankyn
approved these changes
Oct 19, 2021
|
run/idp-sql failures unrelated |
|
rebuilding 3.10 to see if the iot is a flake |
|
Confirmed 3.10 failures unrelated! |
leahecole
added a commit
that referenced
this pull request
Nov 16, 2021
* Use timezone aware datetimes * fix: use datetime.isoformat() * Update custom_metric.py * Update custom_metric.py * Update custom_metric.py * Revert composer changes, add comment instead * fix header-check Co-authored-by: Leah Cole <[email protected]> Co-authored-by: Leah E. Cole <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #6581.
This was a find/replace across the repo. If a timezone aware datetime is not appropriate for your sample please let me know!