Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate theta-module readout and related code to k4geo #56

Closed
wants to merge 4 commits into from
Closed

migrate theta-module readout and related code to k4geo #56

wants to merge 4 commits into from

Conversation

giovannimarchiori
Copy link
Contributor

Code changes related to k4geo migration of FCC segmentation classes and related utilities

kjvbrt
kjvbrt reviewed Nov 14, 2023
View reviewed changes
CMakeLists.txt Outdated Show resolved Hide resolved
@kjvbrt
Copy link
Contributor

kjvbrt commented Nov 14, 2023 •
edited
Loading

Hi @giovannimarchiori , I assume this passes all the tests run locally with the correct version of k4Geo.

@kjvbrt
Copy link
Contributor

kjvbrt commented Nov 14, 2023

Can you also separte k4FWCore from the k4Geo includes?
So from this:

// k4
#include "detectorSegmentations/FCCSWGridPhiEta_k4geo.h"
#include "k4Interface/INoiseCaloCellsTool.h"
#include "k4Interface/ICellPositionsTool.h"

to this:

// k4Geo
#include "detectorSegmentations/FCCSWGridPhiEta_k4geo.h"

// k4FWCore
#include "k4Interface/INoiseCaloCellsTool.h"
#include "k4Interface/ICellPositionsTool.h"

@giovannimarchiori
Copy link
Contributor Author

giovannimarchiori commented Nov 14, 2023 •
edited
Loading

Hi @giovannimarchiori , I assume this passes all the tests run locally with the correct version of k4Geo.

indeed, but for the moment only for local changes to k4geo not merged yet. These are now being ported to k4geo via a separate PR key4hep/k4geo#298 so once that one is merged I will check again that everything works fine locally and let you know

@giovannimarchiori giovannimarchiori mentioned this pull request Nov 20, 2023
Merged
@giovannimarchiori
Copy link
Contributor Author

Superseded by #59 - closing this PR

@giovannimarchiori giovannimarchiori deleted the gmarchio-main-20231103-k4geomigration-FCCDetPR63 branch November 20, 2023 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjvbrt kjvbrt kjvbrt left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@giovannimarchiori @kjvbrt