Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump OHIF version + add option to disable servers cache #86

Closed
wants to merge 33 commits into from
Closed

Bump OHIF version + add option to disable servers cache #86

wants to merge 33 commits into from

Conversation

igoroctaviano
Copy link
Collaborator

  • Bump OHIF version + add option to disable servers cache

qqalexqq and others added 30 commits April 5, 2021 09:47
@qqalexqq
fix: Update Dockerfile node version - fix missing dependencies (OHIF#…
2f443fa 
…2349)

There were some utilities missing: python, make, g++. Also node version was too old - current node builds without problems.
@Punzo
IDC2259: do not check uniform spacing in the 4th dimension for 4D dat…
9bbdb35 
…asets (OHIF#2356)
@Punzo
IDC2346: fix images sorting (OHIF#2358)
4bb3670
@Punzo
IDC2345: Update dcmjs to version 0.18.4 (OHIF#2362)
e55b909
@igoroctaviano
fix(wl): fix metadata provider window level issues after dicomweb upd…
8681036 
…ate (string vs number)
@igoroctaviano
Merge branch 'master' of github.com:OHIF/Viewers into fix/window-leve…
538555f 
…l-issues
@igoroctaviano
Rollback circle ci test
c6bc19c
@igoroctaviano
Comment cache
f85f856
@igoroctaviano
Merge pull request OHIF#2363 from OHIF/fix/window-level-issues
29afddb 
fix(MetadataProvider): Update metadata provider to resolve issues after dicomweb update/new return value
@ohif-bot
chore(release): publish [skip ci]
a08caa9 
 - @ohif/[email protected]
 - @ohif/[email protected]
 - @ohif/[email protected]
 - @ohif/[email protected]
 - @ohif/[email protected]
 - @ohif/[email protected]
 - @ohif/[email protected]
 - @ohif/[email protected]
@Punzo
IDC2345: implement thumbnails footnotes UI for segmentation series in…
07b272e 
…consistencies warning (OHIF#2364)

* IDC2345: implement thumbnails footnotes UI for segmentation series inconsistencies warning
@ohif-bot
chore(release): publish [skip ci]
d2e75b0 
 - @ohif/[email protected]
 - @ohif/[email protected]
 - @ohif/[email protected]
 - @ohif/[email protected]
@Punzo
IDC2361: fix seg combobox filling
e41ba2b
@Punzo
update
e421bc7
@Punzo
update
21a5d1b
@igoroctaviano
Merge pull request OHIF#2369 from Punzo/IDC2361
274342a 
Re OHIF#2361: fix seg combobox filling
@ohif-bot
chore(release): publish [skip ci]
1d069d2 
 - @ohif/[email protected]
 - @ohif/[email protected]
 - @ohif/[email protected]
 - @ohif/[email protected]
@igoroctaviano
IDC-2348: Add acquisition storage sr sopclass to sr html ext (OHIF#2352)
0ae49c6 
* Add acquisition context storage sr sop to html ext
@ohif-bot
chore(release): publish [skip ci]
a822151 
 - @ohif/[email protected]
 - @ohif/[email protected]
 - @ohif/[email protected]
 - @ohif/[email protected]
@Punzo
IDC2345: update dcmjs to version 0.18.5 (OHIF#2378)
2b658fa
@ohif-bot
chore(release): publish [skip ci]
82ddd95 
 - @ohif/[email protected]
 - @ohif/[email protected]
 - @ohif/[email protected]
 - @ohif/[email protected]
 - @ohif/[email protected]
 - @ohif/[email protected]
 - @ohif/[email protected]
@dannyrb
Remove broken plugin? Seems to have broken child dep
6f16c7e
@dannyrb
Merge branch 'master' of github.com:OHIF/Viewers into ups-master
54dd738
@ohif-bot
chore(release): publish [skip ci]
410ab02 
 - @ohif/[email protected]
 - @ohif/[email protected]
 - @ohif/[email protected]
 - @ohif/[email protected]
 - @ohif/[email protected]
 - @ohif/[email protected]
 - @ohif/[email protected]
@dannyrb
remove sitemap dep from older version
a3cb9da
@dannyrb
Merge branch 'master' of github.com:OHIF/Viewers into ups-master
e2bb647
@ohif-bot
chore(release): publish [skip ci]
343f06c 
 - @ohif/[email protected]
 - @ohif/[email protected]
 - @ohif/[email protected]
 - @ohif/[email protected]
 - @ohif/[email protected]
 - @ohif/[email protected]
 - @ohif/[email protected]
@igoroctaviano
Add option to disable local storage cache of servers
1cbef86
@igoroctaviano
Update config property
4b508b0
@igoroctaviano
Merge pull request OHIF#2409 from OHIF/feat/add-option-to-disable-ser…
3b6c637 
…vers-cache

IDC: Add option to disable local storage of servers
@igoroctaviano igoroctaviano requested a review from Punzo May 14, 2021 02:05
@igoroctaviano igoroctaviano self-assigned this May 14, 2021
@igoroctaviano
Copy link
Collaborator Author

@Punzo This should fix the cache issue with servers.

Testing steps:

  • Run the viewer pointing to some random server (dcmjs.org)
  • Update default.js file to point to an invalid server
  • Refresh the viewer (without clearing the cache)
  • The viewer should fail (config to disable cache worked)
  • Try flipping the disableServersCache property to false and try modified the server
  • The viewer shouldn't be able to update the servers without cleaning the cache

After testing + reviewing the code, you can merge. Feel free to include more items in this pull request tomorrow morning if you want to bring more stuff to deploy.

@Punzo
Copy link

Punzo commented May 14, 2021 •
edited
Loading

@Punzo This should fix the cache issue with servers.

Testing steps:

  • Run the viewer pointing to some random server (dcmjs.org)
  • Update default.js file to point to an invalid server
  • Refresh the viewer (without clearing the cache)
  • The viewer should fail (config to disable cache worked)
  • Try flipping the disableServersCache property to false and try modified the server
  • The viewer shouldn't be able to update the servers without cleaning the cache

After testing + reviewing the code, you can merge. Feel free to include more items in this pull request tomorrow morning if you want to bring more stuff to deploy.

great! I will test on Monday, today feeling a little bit dazy because of the vaccine shot. Could you please also test and review OHIF#2397 ? It would be great if we can add that PR as well into IDC fork. Thanks!

Punzo
Punzo approved these changes May 17, 2021
View reviewed changes
Copy link

@Punzo Punzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested, lgtm!

@Punzo Punzo mentioned this pull request May 17, 2021
Merged
@Punzo
Copy link

Punzo commented May 17, 2021

overdensed by #87

@Punzo Punzo closed this May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Punzo Punzo Punzo approved these changes

Assignees

@igoroctaviano igoroctaviano

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@igoroctaviano @Punzo @qqalexqq @ohif-bot @dannyrb