-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: #466, #481, #378, #377, #365, #462, #463, #380, #393, #445 #492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To ensure frontend image builds can distinguish between different environments, an additional distinction based on the environment tag has been introduced. This change was necessary as the commit altering the frontend module alone was insufficient. By adding an environment tag to the image tag name, applications with the same version can now be uniquely identified across various environments. Changes Made: - Modified the Makefile in the govtool/frontend directory to introduce an environment tag to the image tag name used in frontend image builds. The new tag is generated by appending the environment variable to the commit hash obtained from the git log command, ensuring each build is uniquely identified per environment.
…-compose-stack-for-proper-frontend-image-tagging [#466] Enhancing Docker Compose stack for proper frontend image tagging
[#453] Storybook update
To ensure frontend image builds can distinguish between different environments, an additional distinction based on the environment tag has been introduced. This change was necessary as the commit altering the frontend module alone was insufficient. By adding an environment tag to the image tag name, applications with the same version can now be uniquely identified across various environments. Changes Made: - Modified the Makefile in the govtool/frontend directory to introduce an environment tag to the image tag name used in frontend image builds. The new tag is generated by appending the environment variable to the commit hash obtained from the git log command, ensuring each build is uniquely identified per environment.
…n-of-the-metadata [#378] feat: add hash and validation of the metadata
GA submitter complete flow
…storage-information-screen [#364] fix: i18n labels of storage information screen
[#451] fix: whitelist githubusercontent and ipfs io in CSP to allow fetching the jsonld file
…ernal-url-is-show-outside-the-view fix/481-ga-details-long-external-url-is-show-outside-the-view
fix/462/463
…da-amount [#377] fix: validation of ada amount
[#377] fix validation of ada amount
MSzalowski
requested review from
Sworzen1,
JanJaroszczak and
kickloop
as code owners
March 15, 2024 16:05
MSzalowski
requested review from
kickloop and
Ryun1
and removed request for
kickloop,
Sworzen1 and
JanJaroszczak
March 15, 2024 16:05
pmbinapps
approved these changes
Mar 15, 2024
MSzalowski
changed the title
Test
test: #466, #481, #378, #377, #365, #462, #463, #380, #393, #445
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of changes