add misc summary stats #1085

rajnikantsh · 2018-12-26T22:28:57Z

Fixed #1084
add summary stats for averageVehicleDelayPerTrip and averageRidehailWaitTime

This change is

JustinPihony

The issue is vague, so I'll let Rashid be the final check on if these are the stats he wanted. But the possible NPE is a blocker in itself.

JustinPihony · 2018-12-27T03:30:00Z

src/main/java/beam/analysis/plots/RideHailWaitingAnalysis.java

@@ -216,6 +217,13 @@ public void createGraph(IterationEndsEvent event) throws IOException {
        writeRideHailWaitingIndividualStatCSV(event.getIteration());
    }

+    @Override
+    public Map<String, Double> getSummaryStats(){
+        Map<String, Double> averageRidehailWaitTime = new HashMap();


How about just one lining this:

return new HashMap<String, Double>() {{ put("averageRidehailWaitTime" , waitTimeSum / rideHailCount); }};

Hi @JustinPihony, I have made this change.

JustinPihony · 2018-12-27T03:30:05Z

src/main/java/beam/analysis/summary/VehicleTravelTimeAnalysis.java

@@ -20,19 +30,47 @@ public void processStats(Event event) {
                    Double.parseDouble(eventAttributes.get(PathTraversalEvent.ATTRIBUTE_DEPARTURE_TIME)));

            secondsTraveledByVehicleType.merge(vehicleType, hoursTraveled, (d1, d2) -> d1 + d2);
+
+
+            if (vehicleType.contains("Car") || vehicleType.contains("BUS")){


We have a number of different ways to handle something like this. @colinsheppard is there something I missed, or should I open an issue to try to create a static way to check vehicle type? Probably from BeamVehicleType.scala. This code is fine atm - I'm just using it as a reference point at this time.

mode should have been compared here @rajnikantsh, not vehicleType

src/main/java/beam/analysis/summary/VehicleTravelTimeAnalysis.java

Changes have been - made, but leaving the approval to Rashid since I can't tell from the issue whether the intended implementation is what is wanted.

JustinPihony · 2018-12-27T18:49:42Z

To be clear - the code LGTM, but @wrashid will have to check if it's what he asked

src/main/java/beam/analysis/summary/PersonCostAnalysis.java

src/main/java/beam/analysis/summary/VehicleTravelTimeAnalysis.java

src/main/java/beam/analysis/plots/RideHailWaitingAnalysis.java

src/main/java/beam/analysis/summary/VehicleTravelTimeAnalysis.java

src/main/java/beam/analysis/plots/RideHailWaitingAnalysis.java

…t in hours

src/main/java/beam/analysis/plots/RideHailWaitingAnalysis.java

)

src/main/java/beam/analysis/summary/VehicleTravelTimeAnalysis.java

* add misc summary stats (#1085) * add misc summary stats * add null check and change return syntax * refactoring * bug fix: wrong field used * refactor: reuse code * add totalHoursOfVehicleTrafficDelay in summary stats. * add summary stats for averagePTWaitingTime * add bus crowding in summary stats * reset bus crowding * add averageTripExpenditure in summary stats * fixed cost aggregation * fixed PTCrowding (bus) * renamed to totalNetCost * fixed warnings * reset ptWaiting against personId * fixed average and update labels * hoursTraveled should be renamed to travelDurationInSec, as this is not in hours * remove / 3600 for busCrowding * fixed hard coding of modes * fixed hard coding of modes * rename _person * fixed warnings and format * create summary stats for average vehicle delay for motorized leg. (#1095) * fixed numOfTimesBusTaken in busCrowding * changed buses list to set * fixed averageVehicleDelay * fixed delay stat variable name * fixed delay stats calculation * fix n/0 issue * fix totalVehicles for averageDelays * fix failing run for sf-light scenario (#1097) * fix sf-light run * fix comment * can give too much logging when vehicles misconfigured so make exponential * Cs/#1099 rhm batch and repos (#1104) * initial attempt to enable co-execution of these processes, still buggy * debugging * found bug related to new requests coming in while buffered requests being processed, more robust now * fixing regression * another glitch solved * finally getting simultaneous timeouts working * fmt * allow pass when not in batch mode * ignore failing test * debug statements mistakently lefts as info * summary stats modification (#1110) * Merge remote-tracking branch 'remotes/origin/master' into rajnikantsh/#1008-extract-matsim-conf-4ci # Conflicts: # test/input/sf-light/sf-light-1k.conf add averageVehicleTravelPerPassengerTrip and averageTravelExpenditure for each activity * changed variable name * Cs/#1082 refine analysis (#1109) * turns into case objects, change delay metric bins * change delay metric plot (#1083) * change plot for delay metric * Scala fmt * resolved average delay graph issue * more descriptive titles * space * debugging non-deterministic stuck issue * fmt * repairing the fallback BeamPath used for transit trips that can't be … (#1106) * repairing the fallback BeamPath used for transit trips that can't be routed to avoid exceptions later on (cherry picked from commit 2cd4bdc) * scalafmt * ignore flaky test. * Cs/#1100 Refactor (#1113) * decompose some code from RHM into new class to clear things a bit * fmt * clean * extract matsim properties from beam.conf to matsim.conf (#1061) * extract matsim properties from beam.conf to matsim.conf * fmt * set param in beam config and referred in matsim config * renaming and moving * better default for iters * remaining changes in extracting matsim config * Merge remote-tracking branch 'remotes/origin/master' into rajnikantsh/#1008-extract-matsim-conf-4ci # Conflicts: # test/input/sf-light/sf-light-1k.conf reset agent number in sf-light-2.5k * renaming and reogranizing params * renaming and repositioning of sf-light * fmt * extract matsim from base conf * Merge branch 'master' into rajnikantsh/1115-extract-baseconf-4ci

add misc summary stats

17478be

rajnikantsh requested a review from wrashid December 26, 2018 22:28

ghost assigned rajnikantsh Dec 26, 2018

ghost added the Review label Dec 26, 2018

JustinPihony previously requested changes Dec 27, 2018

View reviewed changes

add null check and change return syntax

f424bf7

wrashid added 2 commits December 27, 2018 13:07

refactoring

2b592f6

bug fix: wrong field used

28e1ef0

ghost assigned wrashid Dec 27, 2018

wrashid and others added 7 commits December 27, 2018 13:09

refactor: reuse code

264fd05

add totalHoursOfVehicleTrafficDelay in summary stats.

89a3f33

add summary stats for averagePTWaitingTime

9512003

add bus crowding in summary stats

1e47ea0

reset bus crowding

a6a41e0

add averageTripExpenditure in summary stats

868fca1

fixed cost aggregation

1be997b

ghost assigned zishanbilal Dec 28, 2018

wrashid reviewed Dec 28, 2018

View reviewed changes

src/main/java/beam/analysis/summary/PersonCostAnalysis.java Outdated Show resolved Hide resolved

wrashid reviewed Dec 28, 2018

View reviewed changes

src/main/java/beam/analysis/summary/VehicleTravelTimeAnalysis.java Outdated Show resolved Hide resolved

wrashid reviewed Dec 28, 2018

View reviewed changes

src/main/java/beam/analysis/plots/RideHailWaitingAnalysis.java Outdated Show resolved Hide resolved

wrashid reviewed Dec 28, 2018

View reviewed changes

src/main/java/beam/analysis/plots/RideHailWaitingAnalysis.java Outdated Show resolved Hide resolved

wrashid reviewed Dec 28, 2018

View reviewed changes

src/main/java/beam/analysis/plots/RideHailWaitingAnalysis.java Outdated Show resolved Hide resolved

wrashid reviewed Dec 28, 2018

View reviewed changes

src/main/java/beam/analysis/summary/VehicleTravelTimeAnalysis.java Outdated Show resolved Hide resolved

fixed PTCrowding (bus)

f50c8ef

wrashid reviewed Dec 28, 2018

View reviewed changes

src/main/java/beam/analysis/summary/VehicleTravelTimeAnalysis.java Outdated Show resolved Hide resolved

wrashid reviewed Dec 28, 2018

View reviewed changes

src/main/java/beam/analysis/summary/VehicleTravelTimeAnalysis.java Outdated Show resolved Hide resolved

Zeeshan Bilal added 2 commits December 28, 2018 06:03

renamed to totalNetCost

25b3fd9

fixed warnings

624d95c

reset ptWaiting against personId

73d3392

wrashid reviewed Dec 28, 2018

View reviewed changes

src/main/java/beam/analysis/plots/RideHailWaitingAnalysis.java Outdated Show resolved Hide resolved

Zeeshan Bilal added 4 commits December 28, 2018 06:34

fixed average and update labels

360b39e

hoursTraveled should be renamed to travelDurationInSec, as this is no…

1ae9793

…t in hours

remove / 3600 for busCrowding

2725231

fixed hard coding of modes

7a160a3

wrashid reviewed Dec 28, 2018

View reviewed changes

src/main/java/beam/analysis/plots/RideHailWaitingAnalysis.java Outdated Show resolved Hide resolved

Zeeshan Bilal added 3 commits December 28, 2018 07:02

fixed hard coding of modes

476eb75

rename _person

65e326d

fixed warnings and format

9cc0301

zishanbilal requested review from zishanbilal and removed request for zishanbilal December 28, 2018 02:13

zishanbilal approved these changes Dec 28, 2018

View reviewed changes

rajnikantsh and others added 3 commits December 28, 2018 17:18

create summary stats for average vehicle delay for motorized leg. (#1095

28c7be6

)

fixed numOfTimesBusTaken in busCrowding

1050166

changed buses list to set

76e0ef4

wrashid reviewed Dec 29, 2018

View reviewed changes

src/main/java/beam/analysis/summary/VehicleTravelTimeAnalysis.java Outdated Show resolved Hide resolved

Zeeshan Bilal added 6 commits December 30, 2018 16:59

fixed averageVehicleDelay

c167545

fixed delay stat variable name

7306232

Merge branch 'master' into rajnikantsh/#1084-add-misc-summarystats-4ci

f860b7e

fixed delay stats calculation

67b9669

fix n/0 issue

e851285

fix totalVehicles for averageDelays

b0bc67e

wrashid approved these changes Dec 31, 2018

View reviewed changes

Merge branch 'master' into rajnikantsh/#1084-add-misc-summarystats-4ci

118bab9

zishanbilal merged commit 067a827 into master Dec 31, 2018

ghost removed the Review label Dec 31, 2018

zishanbilal deleted the rajnikantsh/#1084-add-misc-summarystats-4ci branch December 31, 2018 19:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add misc summary stats #1085

add misc summary stats #1085

rajnikantsh commented Dec 26, 2018 •

edited by zishanbilal

Loading

JustinPihony left a comment

JustinPihony Dec 27, 2018

rajnikantsh Dec 27, 2018

JustinPihony Dec 27, 2018

wrashid Dec 27, 2018 •

edited

Loading

JustinPihony commented Dec 27, 2018

add misc summary stats #1085

add misc summary stats #1085

Conversation

rajnikantsh commented Dec 26, 2018 • edited by zishanbilal Loading

JustinPihony left a comment

Choose a reason for hiding this comment

JustinPihony Dec 27, 2018

Choose a reason for hiding this comment

rajnikantsh Dec 27, 2018

Choose a reason for hiding this comment

JustinPihony Dec 27, 2018

Choose a reason for hiding this comment

wrashid Dec 27, 2018 • edited Loading

Choose a reason for hiding this comment

JustinPihony commented Dec 27, 2018

rajnikantsh commented Dec 26, 2018 •

edited by zishanbilal

Loading

wrashid Dec 27, 2018 •

edited

Loading