extract matsim from base conf in production-sfbay #1116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add misc summary stats * add null check and change return syntax * refactoring * bug fix: wrong field used * refactor: reuse code * add totalHoursOfVehicleTrafficDelay in summary stats. * add summary stats for averagePTWaitingTime * add bus crowding in summary stats * reset bus crowding * add averageTripExpenditure in summary stats * fixed cost aggregation * fixed PTCrowding (bus) * renamed to totalNetCost * fixed warnings * reset ptWaiting against personId * fixed average and update labels * hoursTraveled should be renamed to travelDurationInSec, as this is not in hours * remove / 3600 for busCrowding * fixed hard coding of modes * fixed hard coding of modes * rename _person * fixed warnings and format * create summary stats for average vehicle delay for motorized leg. (#1095) * fixed numOfTimesBusTaken in busCrowding * changed buses list to set * fixed averageVehicleDelay * fixed delay stat variable name * fixed delay stats calculation * fix n/0 issue * fix totalVehicles for averageDelays
* fix sf-light run * fix comment
* initial attempt to enable co-execution of these processes, still buggy * debugging * found bug related to new requests coming in while buffered requests being processed, more robust now * fixing regression * another glitch solved * finally getting simultaneous timeouts working * fmt * allow pass when not in batch mode * ignore failing test
* Merge remote-tracking branch 'remotes/origin/master' into rajnikantsh/#1008-extract-matsim-conf-4ci # Conflicts: # test/input/sf-light/sf-light-1k.conf add averageVehicleTravelPerPassengerTrip and averageTravelExpenditure for each activity * changed variable name
* extract matsim properties from beam.conf to matsim.conf * fmt * set param in beam config and referred in matsim config * renaming and moving * better default for iters * remaining changes in extracting matsim config * Merge remote-tracking branch 'remotes/origin/master' into rajnikantsh/#1008-extract-matsim-conf-4ci # Conflicts: # test/input/sf-light/sf-light-1k.conf reset agent number in sf-light-2.5k * renaming and reogranizing params * renaming and repositioning of sf-light * fmt
ghost
assigned 
colinsheppard
approved these changes
Jan 7, 2019
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
colinsheppard
approved these changes
Jan 7, 2019
There was a problem hiding this comment.
Reviewed 47 of 47 files at r2.
Reviewable status:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
created new matsim conf and referred to base conf .
This change is