NeuroML 2.2 release #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create python-publish.yml
We go up the inheritance tree and gather all the exposures. TODO: is there no way in the pyLEMS API already that allows us to do this in an easier way?
…ures are also listed
Update list_exposures to also get inherited exposures
Descriptions can include `" .. "` and when these are read, they're converted to `" .."` internally. We need to make sure these are escaped correctly so that when the internal XML string is passed to parsers (like the minidom parser), it is still valid.
These are needed by the regression test for issue 20. We could come up with a regression test that does not require these, or use pyNeuroML to get these on demand, but for the time being I'm checking these in.
If the startup handlers are run before them, then even though the code does initialise variables, it does it in the wrong order. For example, for `v = initMembPot` that is a `StateAssignment` that should happen `OnStart`, `initMembPot` needs to be processed first so that `v` can then pick up its value. Fixes #20
CI checks that examples here and in jLEMS are identical.
fix(parser): quote text in the description attribute
This reverts commit 6aa1645.
I forgot that the ref for the PR may not exist in the other repo.
feat: sync examples with jlems and add CI
Fix issue 20
The method only gets paths for exposures, so we change the name to make it more specific.
Previously, when we used `self.components,` we only got the top level components because that's what `self.components` holds. Now, we use `self.components` as a starting point and recursively find all child/children components also.
We can now list paths for all exposures that can be obtained from the model declaration. We do not build a simulation of the model, so exposures, connections, and other elements (and so their exposures) that are created at build time are not included.
Add assertions to check for paths for multi-instantiated Population component.
This ensures that later list modifications do not affect stored information.
Feat/recursively get components
fix(dependencies): install typing for py<3.5 only
feat: format with black
docs: add man page
Abusing `data_files` seems to be the simplest way of doing this. pypa/packaging-problems#72 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.