Skip to content
This repository has been archived by the owner on Jul 15, 2022. It is now read-only.

LL-8115 Correctly filter out change output from recipients #1519

Merged
merged 4 commits into from
Nov 12, 2021
Merged

Conversation

ghost
Copy link

@ghost ghost commented Nov 12, 2021

Context (issues, jira)

https://ledgerhq.atlassian.net/browse/LL-8115

Description / Usage

Filtering of the change output was incorrect, fix the logic doing it.

Expectations

  • Test coverage: The changes of this PR are covered by test. Unit test were added with mocks when depending on a backend/device.
  • No impact: The changes of this PR have ZERO impact on the userland. Meaning, we can use these changes without modifying LLD/LLM at all. It will be a "noop" and the maintainers will be able to bump it without changing anything.

@ghost ghost self-assigned this Nov 12, 2021
@ghost ghost self-requested a review November 12, 2021 17:00
@vercel
Copy link

vercel bot commented Nov 12, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/ledgerhq/ledger-live-common/6x9v9ay1eMaAYGECzUrTfzLzgBFG
✅ Preview: https://ledger-live-common-git-ll-8115-ledgerhq.vercel.app

@ghost ghost requested review from a team, gre and hzheng-ledger and removed request for a team November 12, 2021 17:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants