Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: displayName in the textile explorer, reordered columns #737

Merged
merged 11 commits into from
Sep 12, 2024

Conversation

ccomb
Copy link
Collaborator

@ccomb ccomb commented Sep 11, 2024

Story

ecobalyse-private: textile_explorer

@ccomb ccomb changed the title Changes to the textile explorer to be more like the food explorer feature: displayName in the textile explorer, reordered columns Sep 11, 2024
@ccomb ccomb changed the title feature: displayName in the textile explorer, reordered columns feat: displayName in the textile explorer, reordered columns Sep 11, 2024
Copy link
Member

@n1k0 n1k0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with a few remarks and suggestions

data/README.md Show resolved Hide resolved
data/notebooks/explore.py Outdated Show resolved Hide resolved
src/Data/Food/Process.elm Outdated Show resolved Hide resolved
src/Data/Textile/Process.elm Outdated Show resolved Hide resolved
src/Page/Explore/FoodProcesses.elm Outdated Show resolved Hide resolved
src/Page/Explore/TextileProcesses.elm Outdated Show resolved Hide resolved
@ccomb ccomb merged commit 65d0ed5 into master Sep 12, 2024
7 checks passed
@ccomb ccomb deleted the textile_explorer branch September 12, 2024 09:41
vjousse pushed a commit that referenced this pull request Sep 25, 2024
[2.3.0](v2.2.0...v2.3.0)
(2024-09-25)


### Features

* add link to changelog in app footer.
([#748](#748))
([efe88f5](efe88f5))
* airTransportRatio should depend on durability
([#757](#757))
([a0761d1](a0761d1))
* displayName in the textile explorer, reordered columns
([#737](#737))
([65d0ed5](65d0ed5))


### Bug Fixes

* **api:** handle ingredient plane transport in food POST api.
([#769](#769))
([62587e2](62587e2))
* check db integrity after building it
([#753](#753))
([5b41ef6](5b41ef6))
* check uniqueness of JSON db primary keys at build time.
([#766](#766))
([0927954](0927954))
* decode and validate all optionals.
([#764](#764))
([87a7c6a](87a7c6a))
* encode physicalDurability parameter.
([#751](#751))
([f6750b8](f6750b8))
* fix github CI python build setup.
([#762](#762))
([ea2cd9f](ea2cd9f))
* fixed brightway explorer notebook error (wrong key)
([#745](#745))
([bc436c2](bc436c2))
* in brightway explorer: improve display of compartment categories, if
any ([#754](#754))
([757d5a6](757d5a6))
* stricter validation of POST json body passed to the textile API.
([#760](#760))
([a85bd8a](a85bd8a))
* **textile:** distribution step had no inland road transports added.
([#761](#761))
([d789d7d](d789d7d))
* Update export outside of EU probability.
([#765](#765))
([c3fd9f2](c3fd9f2))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
n1k0 pushed a commit that referenced this pull request Sep 26, 2024
[2.3.0](v2.2.0...v2.3.0)
(2024-09-25)


### Features

* add link to changelog in app footer.
([#748](#748))
([efe88f5](efe88f5))
* airTransportRatio should depend on durability
([#757](#757))
([a0761d1](a0761d1))
* displayName in the textile explorer, reordered columns
([#737](#737))
([65d0ed5](65d0ed5))


### Bug Fixes

* **api:** handle ingredient plane transport in food POST api.
([#769](#769))
([62587e2](62587e2))
* check db integrity after building it
([#753](#753))
([5b41ef6](5b41ef6))
* check uniqueness of JSON db primary keys at build time.
([#766](#766))
([0927954](0927954))
* decode and validate all optionals.
([#764](#764))
([87a7c6a](87a7c6a))
* encode physicalDurability parameter.
([#751](#751))
([f6750b8](f6750b8))
* fix github CI python build setup.
([#762](#762))
([ea2cd9f](ea2cd9f))
* fixed brightway explorer notebook error (wrong key)
([#745](#745))
([bc436c2](bc436c2))
* in brightway explorer: improve display of compartment categories, if
any ([#754](#754))
([757d5a6](757d5a6))
* stricter validation of POST json body passed to the textile API.
([#760](#760))
([a85bd8a](a85bd8a))
* **textile:** distribution step had no inland road transports added.
([#761](#761))
([d789d7d](d789d7d))
* Update export outside of EU probability.
([#765](#765))
([c3fd9f2](c3fd9f2))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants