fix(api): handle ingredient plane transport in food POST api. #769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vjousse
pushed a commit
that referenced
this pull request
Sep 25, 2024
[2.3.0](v2.2.0...v2.3.0) (2024-09-25) ### Features * add link to changelog in app footer. ([#748](#748)) ([efe88f5](efe88f5)) * airTransportRatio should depend on durability ([#757](#757)) ([a0761d1](a0761d1)) * displayName in the textile explorer, reordered columns ([#737](#737)) ([65d0ed5](65d0ed5)) ### Bug Fixes * **api:** handle ingredient plane transport in food POST api. ([#769](#769)) ([62587e2](62587e2)) * check db integrity after building it ([#753](#753)) ([5b41ef6](5b41ef6)) * check uniqueness of JSON db primary keys at build time. ([#766](#766)) ([0927954](0927954)) * decode and validate all optionals. ([#764](#764)) ([87a7c6a](87a7c6a)) * encode physicalDurability parameter. ([#751](#751)) ([f6750b8](f6750b8)) * fix github CI python build setup. ([#762](#762)) ([ea2cd9f](ea2cd9f)) * fixed brightway explorer notebook error (wrong key) ([#745](#745)) ([bc436c2](bc436c2)) * in brightway explorer: improve display of compartment categories, if any ([#754](#754)) ([757d5a6](757d5a6)) * stricter validation of POST json body passed to the textile API. ([#760](#760)) ([a85bd8a](a85bd8a)) * **textile:** distribution step had no inland road transports added. ([#761](#761)) ([d789d7d](d789d7d)) * Update export outside of EU probability. ([#765](#765)) ([c3fd9f2](c3fd9f2)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
n1k0
added a commit
that referenced
this pull request
Sep 26, 2024
The food API wasn't properly handling the `byPlane` ingredient parameter in `POST`.
n1k0
pushed a commit
that referenced
this pull request
Sep 26, 2024
[2.3.0](v2.2.0...v2.3.0) (2024-09-25) ### Features * add link to changelog in app footer. ([#748](#748)) ([efe88f5](efe88f5)) * airTransportRatio should depend on durability ([#757](#757)) ([a0761d1](a0761d1)) * displayName in the textile explorer, reordered columns ([#737](#737)) ([65d0ed5](65d0ed5)) ### Bug Fixes * **api:** handle ingredient plane transport in food POST api. ([#769](#769)) ([62587e2](62587e2)) * check db integrity after building it ([#753](#753)) ([5b41ef6](5b41ef6)) * check uniqueness of JSON db primary keys at build time. ([#766](#766)) ([0927954](0927954)) * decode and validate all optionals. ([#764](#764)) ([87a7c6a](87a7c6a)) * encode physicalDurability parameter. ([#751](#751)) ([f6750b8](f6750b8)) * fix github CI python build setup. ([#762](#762)) ([ea2cd9f](ea2cd9f)) * fixed brightway explorer notebook error (wrong key) ([#745](#745)) ([bc436c2](bc436c2)) * in brightway explorer: improve display of compartment categories, if any ([#754](#754)) ([757d5a6](757d5a6)) * stricter validation of POST json body passed to the textile API. ([#760](#760)) ([a85bd8a](a85bd8a)) * **textile:** distribution step had no inland road transports added. ([#761](#761)) ([d789d7d](d789d7d)) * Update export outside of EU probability. ([#765](#765)) ([c3fd9f2](c3fd9f2)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Problem
The food API wasn't properly handling the
byPlaneingredient parameter inPOST, see Notion card.🍰 Solution
The patch fixes the issue.
🚨 Points to watch/comments
There's a lot of tech debt in the way we parse the food query, but this would be HUGE work to properly refactor and should probably be assessed and prioritized better at a more appropriate time, so… this patch basically just patches and fixes the issue in the least dirty way.
🏝️ How to test
The test suite still passes, which is good. To test the patch works, ask for the Non-EU Mango to the patched food API (I'm running it againt the local branch and server):