Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No cldfra2d diagnostics saved in RRTMGP #957

Closed
mzhangw opened this issue Aug 30, 2022 · 6 comments
Closed

No cldfra2d diagnostics saved in RRTMGP #957

mzhangw opened this issue Aug 30, 2022 · 6 comments
Labels

Comments

@mzhangw
Copy link
Collaborator

mzhangw commented Aug 30, 2022

There is no cldfra2d diagnostics in RRTMGP as it does in RRTMG. It leads to an incorrect ZERO value of total cloud fraction when RRTMGP is used in SCM.

@mzhangw mzhangw added the bug label Aug 30, 2022
@dustinswales
Copy link
Collaborator

@mzhangw
We need to add the following 5 lines to here, but using cld_frac
@yangfanglin @Qingfu-Liu I can add this fix to my open PR, #956?

@yangfanglin
Copy link
Collaborator

@dustinswales it appears there are already a lot of changes in PR #956. It might be a good idea to merge this to a different PR. It can be included in a PR @Qingfu-Liu is creating to update cloud condensates in cloud cover and radaition calculations.

@dustinswales
Copy link
Collaborator

@yangfanglin That would be excellent.
@Qingfu-Liu

@dustinswales
Copy link
Collaborator

@yangfanglin @Qingfu-Liu @mzhangw
I added a fix to this issue in ufs-community/ccpp-phsyics PR #9

@mzhangw
Copy link
Collaborator Author

mzhangw commented Oct 11, 2022 via email

@grantfirl
Copy link
Collaborator

Fixed in ufs-community#9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants