-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Couple convective cloud to radiation #9
Couple convective cloud to radiation #9
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the change in radiation_clouds routine looks fine
Some of the results from the change in the radiation_clouds routine can be seen |
@dustinswales Could you add Ruiyu's results into the description of this PR? |
@RuiyuSun @ChunxiZhang-NOAA I don't think that link is working. |
The link is (need copy/paste):
https://docs.google.com/presentation/d/14OJnTJZkO4EI-I3UQXLeRd0_AIVUOK9S/edit#slide=id.p11
…On Thu, Sep 29, 2022 at 3:14 PM dustinswales ***@***.***> wrote:
@dustinswales <https://github.com/dustinswales> Could you add Ruiyu's
results into the description of this PR?
@RuiyuSun <https://github.com/RuiyuSun> @ChunxiZhang-NOAA
<https://github.com/ChunxiZhang-NOAA> I don't think that link is working.
—
Reply to this email directly, view it on GitHub
<#9 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGTS6UVV7SZPCPULUBLDKQLWAXTATANCNFSM6AAAAAAQY6NGDU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
@mzhangw @ChunxiZhang-NOAA |
In radiation_clouds.f, Ruiyu's new recommendation is to change line 3909 from clwt = 1.0e-10 * (plyr(i,k)*0.001) to clwt = 1.0e-6 * (plyr(i,k)*0.001). @dustinswales Could you modify it in this PR? |
@dustinswales Please update this to the latest ufs-dev branch when you get a chance in order to start testing. |
@dustinswales Since the CI changes were merged, this needs to be updated to ufs/dev again before testing. |
Couple convective cloud to radiation
Opened on behalf of @Qingfu-Liu, replacing #8
This PR contains adds the convective cloud water (liquid water + ice water) in the calculations of Cloud Water Path and Ice Water Path for radiation cloud properties.
For RRTMG radiation, only one file changed: radiation_clouds.f (code changed by Ruiyu Sun)
For RRTMGP radiation, one file has changed and there is an upstream change needed in NOAA-EMC/fv3atm for a new interstitial variable.
This will change the baselines for any RT using the Thompson MP scheme
TestingAndEvaluation_PR9.pdf