Update fms_mixedmode branch #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t=1,1 adds capability to use FMS feature to ignore data integrity checksums in restarts
…alue for compatibility
* Add missing instance for hailwat * Regional bc blend changes to extend into interior halos and overlap on corners. Still not working for u and v. * atmosphere.F90 : add hailwat to check dyn_core.F90 : Fix from Jun Wang to correct sync of u,v fv_regional_bc.F90 : add check for nrows_blend > tile size; fix error when nrows_blend=1 * Explanatory comment added * Removed commented code * Clean old code
Emc io fixes
* changed interface to public * added public * removed source * mods for jedi build * Transfer changes from PR NOAA-GFDL#202 to NOAA-GFDL#199 Made small changes from PR NOAA-GFDL#202 manually. * returned ignore checksum * fixed ignore checksum
…ncorrectly initialized memory. (NOAA-GFDL#219) * fixes and workarounds for uninitialized memory in fv_regional_bc * remove workarounds and fix remaining known bugs in ps_reg * a few more surface pressure bug fixes; now the test case runs in debug mode * workarounds and bug fixes from gnu compiler testing * remove -9999999 commented-out code * quiet the NaNs passed to Atmp%ps * simplify comments and explain snan * use i-1 & j-1 for two-point averages, when available * Replace many changes with PR NOAA-GFDL#220
| @@ -968,7 +1029,7 @@ subroutine compute_regional_bc_indices(regional_bc_bounds) | |||
| regional_bc_bounds%is_south_uvs=isd | |||
| regional_bc_bounds%ie_south_uvs=ied | |||
| ! | |||
| regional_bc_bounds%js_south_uvs=jed-nhalo_model-nrows_blend+1 | |||
| regional_bc_bounds%js_south_uvs=jed-nhalo_model-nrows_blend+2 | |||
There was a problem hiding this comment.
Why do we need to change the bounds?
There was a problem hiding this comment.
@junwang-noaa For information, please see NOAA-GFDL#219
junwang-noaa
approved these changes
Oct 21, 2022
6 tasks
junwang-noaa
added a commit
that referenced
this pull request
Oct 24, 2022
This reverts commit 0ab12b6.
junwang-noaa
added a commit
that referenced
this pull request
Oct 24, 2022
|
@binli2337 Would you please create a new PR to fms_mixedmode branch? We need to merge it without using squash. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fms_mixedmode branch will be updated to include the latest changes from the dev/emc branch at NOAA-GFDL/GFDL_atmos_cubed_sphere.
Testing has been done on Gaea using fms/2022.03.