Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FMS library not found in CMake build #202

Closed
wants to merge 1 commit into from
Closed

FMS library not found in CMake build #202

wants to merge 1 commit into from

Conversation

aerorahul
Copy link

Description

Fixes #201

How Has This Been Tested?
Since the FV3 dycore is not built as a standalone, this cannot be tested to completion.
However, the cmake configuration now succeeds instead of failing trying to resolve the FMS dependency.

Checklist:

Please check all whether they apply or not

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

mark-a-potts added a commit to mark-a-potts/GFDL_atmos_cubed_sphere that referenced this pull request Jul 25, 2022
@aerorahul
Copy link
Author

absorbed in #199
Thank you @mark-a-potts

@aerorahul aerorahul closed this Jul 25, 2022
laurenchilutti pushed a commit that referenced this pull request Aug 29, 2022
* changed interface to public

* added public

* removed source

* mods for jedi build

* Transfer changes from PR #202 to #199

Made small changes from PR #202 manually.

* returned ignore checksum

* fixed ignore checksum
junwang-noaa pushed a commit to NOAA-EMC/GFDL_atmos_cubed_sphere that referenced this pull request Oct 21, 2022
* fixes io performance issues by making everyone a reader when io_layout=1,1
adds capability to use FMS feature to ignore data integrity checksums in restarts
* rename enforce_rst_cksum to ignore_rst_cksum and change the default value for compatibility
* updated UFS/GFS atmosphere.F90 driver as per @BinLiu-NOAA and @junwang-noaa
* Regional decomposition test fix (when nrows_blend > 0) (NOAA-GFDL#194)
* Add missing instance for hailwat
* Regional bc blend changes to extend into interior halos and overlap on corners. Still not working for u and v.
* atmosphere.F90 : add hailwat to check
dyn_core.F90 : Fix from Jun Wang to correct sync of u,v
fv_regional_bc.F90 : add check for nrows_blend > tile size; fix error when nrows_blend=1

* Explanatory comment added

* Removed commented code

* Clean old code

* In fv_fill.F90, use kind_phys for kind_phys instead of hard-coding 8 byte reals. (NOAA-GFDL#193)

* Expose remap_scalar and remap_dwinds to fv3-jedi (NOAA-GFDL#199)

* changed interface to public

* added public

* removed source

* mods for jedi build

* Transfer changes from PR NOAA-GFDL#202 to NOAA-GFDL#199

Made small changes from PR NOAA-GFDL#202 manually.

* returned ignore checksum

* fixed ignore checksum

* Fix several bugs in fv_regional_bc.F90 relating to uninitialized or incorrectly initialized memory. (NOAA-GFDL#219)

* fixes and workarounds for uninitialized memory in fv_regional_bc

* remove workarounds and fix remaining known bugs in ps_reg

* a few more surface pressure bug fixes; now the test case runs in debug mode

* workarounds and bug fixes from gnu compiler testing

* remove -9999999 commented-out code

* quiet the NaNs passed to Atmp%ps

* simplify comments and explain snan

* use i-1 & j-1 for two-point averages, when available

* Replace many changes with PR NOAA-GFDL#220

Co-authored-by: Rusty.Benson <[email protected]>
Co-authored-by: Ted Mansell <[email protected]>
Co-authored-by: Rusty Benson <[email protected]>
Co-authored-by: Samuel Trahan (NOAA contractor) <[email protected]>
Co-authored-by: Mark Potts <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant