32-bit physics with FV3_RAP #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junwang-noaa
approved these changes
May 13, 2022
This was referenced Jun 24, 2022
SamuelTrahanNOAA
force-pushed
the
sing_prec_from_main
branch
from
eacc6c0
to
e21e73a
Compare
|
@DusanJovic-NOAA can you review this pr? Jun is off this week. @SamuelTrahanNOAA @bensonr @DomHeinzeller can you add another reviewer? ufs-wm pr1215 is ready. |
climbfuji
approved these changes
Jul 19, 2022
|
I cannot add reviewers to this repository. |
DusanJovic-NOAA
approved these changes
Jul 19, 2022
|
@laurenchilutti I think it's good enough if I approve this once (i.e. please remove DomHeinzeller from the list of reviewers). Jun is leave this week, and with Dusan's blessing we should be ok? |
|
I just removed DomHeinzzeller. Is there anyone else you would like me to add or remove as a reviewer? |
Thanks, Laura, I think we are good to go. |
laurenchilutti
approved these changes
Jul 19, 2022
junwang-noaa
pushed a commit
to NOAA-EMC/GFDL_atmos_cubed_sphere
that referenced
this pull request
Oct 21, 2022
* fixes io performance issues by making everyone a reader when io_layout=1,1 adds capability to use FMS feature to ignore data integrity checksums in restarts * rename enforce_rst_cksum to ignore_rst_cksum and change the default value for compatibility * updated UFS/GFS atmosphere.F90 driver as per @BinLiu-NOAA and @junwang-noaa * Regional decomposition test fix (when nrows_blend > 0) (NOAA-GFDL#194) * Add missing instance for hailwat * Regional bc blend changes to extend into interior halos and overlap on corners. Still not working for u and v. * atmosphere.F90 : add hailwat to check dyn_core.F90 : Fix from Jun Wang to correct sync of u,v fv_regional_bc.F90 : add check for nrows_blend > tile size; fix error when nrows_blend=1 * Explanatory comment added * Removed commented code * Clean old code * In fv_fill.F90, use kind_phys for kind_phys instead of hard-coding 8 byte reals. (NOAA-GFDL#193) * Expose remap_scalar and remap_dwinds to fv3-jedi (NOAA-GFDL#199) * changed interface to public * added public * removed source * mods for jedi build * Transfer changes from PR NOAA-GFDL#202 to NOAA-GFDL#199 Made small changes from PR NOAA-GFDL#202 manually. * returned ignore checksum * fixed ignore checksum * Fix several bugs in fv_regional_bc.F90 relating to uninitialized or incorrectly initialized memory. (NOAA-GFDL#219) * fixes and workarounds for uninitialized memory in fv_regional_bc * remove workarounds and fix remaining known bugs in ps_reg * a few more surface pressure bug fixes; now the test case runs in debug mode * workarounds and bug fixes from gnu compiler testing * remove -9999999 commented-out code * quiet the NaNs passed to Atmp%ps * simplify comments and explain snan * use i-1 & j-1 for two-point averages, when available * Replace many changes with PR NOAA-GFDL#220 Co-authored-by: Rusty.Benson <[email protected]> Co-authored-by: Ted Mansell <[email protected]> Co-authored-by: Rusty Benson <[email protected]> Co-authored-by: Samuel Trahan (NOAA contractor) <[email protected]> Co-authored-by: Mark Potts <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for 32-bit physics to the FV3, based on prior work on the Neptune model. The 64-bit physics should not change results. The only change in this repository is to get kind_phys from the model, to ensure its size is correct.
See the top-level PR here for details:
ufs-community/ufs-weather-model#1215
The issue for this is here:
ufs-community/ufs-weather-model#1288