Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update gsd/develop from master 2020/10/01 #8

Merged
merged 15 commits into from
Oct 2, 2020
Merged

Update gsd/develop from master 2020/10/01 #8

merged 15 commits into from
Oct 2, 2020

Conversation

climbfuji
Copy link

@climbfuji climbfuji commented Sep 4, 2020 •
edited by DomHeinzeller
Loading

Changes in this PR:

  • minor bugfixes (fix warnings and a Python 3 compatibility change in ccpp_prebuild.py)
  • CCPP dependencies in .meta files
  • remove empty .gitmodules file

Associated PRs:

NOAA-GSL/GFDL_atmos_cubed_sphere#8
#8
NOAA-GSL/ccpp-physics#53
NOAA-GSL/fv3atm#49
NOAA-GSL/ufs-weather-model#41

For regression testing information, see NOAA-GSL/ufs-weather-model#41.

climbfuji and others added 10 commits August 4, 2020 13:48
@climbfuji
Correct error in src/ccpp_types.meta
57c4246
@climbfuji
Add [ccpp-scheme-properties] section and capability to parse scheme d…
82aab54 
…ependencies; remove unnecessary [module_name] key from arguments dictionary
@climbfuji
scripts/metadata_table.py, scripts/metadata_parser.py: make [ccpp-sch…
b136485 
…eme-properties] section mandatory
@climbfuji
Further cleanup in scripts/ccpp_prebuild.py
c689af3
@climbfuji
Change [ccpp-scheme-properties] to [ccpp-table-properties], add [ccpp…
ab4e931 
…-table-properties] for module and DDT tables, parse dependencies for module and DDT tables
@climbfuji
Rename has_table_properties to has_property_table, add test if a meta…
93d45b8 
…data header is a property table or not to scripts/metadata_table.py
@climbfuji
scripts/metavar.py: fix warning
25746da
@climbfuji
Preserve case for active attribute in ccpp_prebuild.py
2e41743
@climbfuji
Merge pull request NCAR#317 from climbfuji/metadata_dependencies
8365587 
Add dependencies to metadata
@climbfuji
Merge branch 'master' of https://github.com/NCAR/ccpp-framework into …
20cc39d 
…HEAD
This was referenced Sep 4, 2020
Merged
Merged
Merged
@climbfuji climbfuji marked this pull request as ready for review September 4, 2020 15:14
@DomHeinzeller DomHeinzeller changed the title Update gsd/develop from master 2020/09/03 Update gsd/develop from master 2020/10/01 Oct 1, 2020
@DomHeinzeller DomHeinzeller mentioned this pull request Oct 1, 2020
Merged
tanyasmirnova
tanyasmirnova approved these changes Oct 2, 2020
View reviewed changes
Copy link
Collaborator

@tanyasmirnova tanyasmirnova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No comments on this PR.

@DomHeinzeller DomHeinzeller merged commit 7b8df4b into NOAA-GSL:gsd/develop Oct 2, 2020
@climbfuji climbfuji deleted the update_gsd_develop_from_master_20200903 branch June 27, 2022 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DomHeinzeller DomHeinzeller DomHeinzeller approved these changes

@tanyasmirnova tanyasmirnova tanyasmirnova approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@climbfuji @tanyasmirnova @DomHeinzeller