Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gsd/develop from develop 2020/10/01 #41

Conversation

climbfuji
Copy link

@climbfuji climbfuji commented Sep 4, 2020

Changes in this PR:

  • CCPP dependencies in .meta files
  • update to two-way WW3-atmosphere coupling and fractional grid updates from Moorthi
  • land surface perturbation updates
  • diagnostic 3d instantaneous cloud fractions
  • update to ESMF 8.1.0 bs27 with parallel netCDF
  • cleanup/removal of legacy code, minor bugfixes
  • cleanup of regression testing scripts
  • removal of gnumake-based compile.sh, move tests/compile_cmake.sh to tests/compile.sh and remove first argument

Associated PRs:

NOAA-GSL/GFDL_atmos_cubed_sphere#8
NOAA-GSL/ccpp-framework#8
NOAA-GSL/ccpp-physics#53
NOAA-GSL/fv3atm#49
#41

For regression testing information, see below.

SMoorthi-emc and others added 10 commits August 13, 2020 20:45
Diagnostic cldfra array outputs 3D instantaneous cloud fractions. Works with WSM6, Thompson and GFDL mp schemes.
Provided a bug fix to GFS_restart.F90 with an if condition added in the ifdef CCPP block to test for reflectivity flag.  
No results changed.
* udpate to netcdf 4.7.4 release and esmf810bs21
* update netcdf4.7.4.release and esmf810bs21 on hera
* update module files on dell and cray
* update gcc module and conf file on cray
* update fv3 merged with latest develop branch
* change mom6 src directory in nems
* add a parallel netcdf test
* merge rt_orion.conf into rt.conf
* update nems for ww3 build
* update log files from hera
* remove rt_orion.conf and update orion log files
* update log files from cray and dell
* Updates of hera.gnu build config
* fix esmf810bs21 module and update hera intel and gnu log files
* point fv3 and nems back to NOAA-EMC repo

Co-authored-by: Jun Wang <[email protected]>
Co-authored-by: Dom Heinzeller <[email protected]>
* Chnage default tasks per node on Orion. Cleanup tests configuration files.
* Delete old Theia job card templates
* Remove NAM physics switches from conf/configure.fv3.*, remove endeavor.intel build config, remove tests/rt_cheyenne.conf
* modulefiles/orion.intel/fv3: bugfix, remove old post-intel-sandybridge/8.0.5 module
* Update tests/rt.conf: add cheyenne, remove unnecessary COMPILE lines, rearrange tests
* conf/configure.fv3.orion.intel: remove legacy CCPP-STATIC switches

Co-authored-by: Dusan Jovic <[email protected]>
* update to pre-existing land perts scheme, ready for addition of the new scheme
* updates to land perts scheme, so that namelist input and control_type variables are in generic (i.e., variable agnostic) arrays
* Phil's ccpp changes
* minor bug fix
* Comitting stochastic physics updates
* Comitting FV3 submodules updates
* Updates for minimal set of regression tests.
* lndp sub-module clean-up
* Updates to tests to include new input parameters for revised land pert scheme (lndp).
…nity#191)

* Update modulefiles for cheyenne.{gnu,intel}, gaea.intel, jet.intel; change  modulefile for hera.gnu so that it matches the other modulefiles
* Correct typo EMSF -> ESMF in modulefiles
Add the capability to specify dependencies for CCPP modules/DDTs/schemes in the scheme metadata. This allows us to remove the DDT/scheme dependency information from the CCPP prebuild config in fv3atm and only compile the dependencies and schemes that are used by the selected suite definition files. Until now, all schemes and scheme dependencies are compiled, regardless whether they are in use in any of the selected suites.

Add compiler flags for gfortran-10

Don't run csawmg tests on Cheyenne, both crash with a "bus error"
MinsukJi-NOAA and others added 7 commits September 9, 2020 10:19
* add ci-related files. update utest
* modify to auto-run different cases based on ci.test
* Improve CI workflow
* Separate builds and tests into different jobs
* Separate input data from build image; instead, use it as a volume before running tests
* Make ci subdirectory to contain ci-related files
* add clean-up after utest run
* add workflow manage files
* move parsing in main.yml to a separate script file
…h, fix RRTMGP regression tests (ufs-community#201)

* Enable inline post for gnumake builds on hera.gnu, cheyenne.intel, cheyenne.gnu; skip-ci
* Update pull request template, use correct Python interpreter when calling ccpp_prebuild.py in CMakeLists.txt; skip-ci
* tests/rt_utils.sh: remove machine-dependent configuration; skip-ci
* Update ESMF from 8.1.0bs21 to 8.1.0bs27 on almost all machines; skip-ci
* Update .gitmodules and submodule pointer for fv3atm for code review and testing; skip-ci
* Fix RRTMGP regression test setups, temporarily disable RRTMGP tests in tests/rt.conf and tests/rt_gnu.conf
* Updates for docker/ci
* Add note about unit test availability to pull request template
* Update rt.sh configuration for jet, remove tests/rt_rrtmgp.conf, add tests/fv3_conf/compile_slurm.IN_jet
* add link_mpi=dbg for debug test
* add dbg_mt in debug option when OPENMP is on
* update log files for hera, orion, wcoss cray and dell; skip-ci
* update hera.gnu log file
* Set DEBUG_LINKMPI=OFF for cheyenne.intel and gaea.intel; fix post library dependencies for cheyenne.{intel,gnu} gnumake config
* Regression test log for cheyenne.intel

Co-authored-by: Jun Wang <[email protected]>
Co-authored-by: Dom Heinzeller <[email protected]>
* update to latest WW3, 
* update to latest NEMS and stochastic physics branches
* point to new baseline in rt.sh
* wcoss_dell_p3 log, wcoss_cray log, hera.intel log,* orion.intel log
- updates `.gitmodules` and the submodule pointer for fv3atm for code review and testing of the following changes in fv3atm and ccpp-physics:
    - add two new cloud overlap methods for RRTMG to ccpp-physics - see detailed description in NCAR/ccpp-physics#477.
    - add necessary variables to `GFS_typedefs.{F90,meta} and fix a few metadata entries - see NOAA-EMC/fv3atm#157
- contains changes from @DusanJovic-NOAA from branch https://github.com/DusanJovic-NOAA/ufs-weather-model/commits/update_compile_script that removes the old gnumake `compile.sh` script and replaces it with the new cmake `compile_cmake.sh` script (which is renamed to `compile.sh`)
- contains follow-up work in the regression test scripts to use `NEMS_COMPILER` throughout instead of a mixture of `NEMS_COMPILER` and `COMPILER` (note: `NEMS_COMPILER` should be renamed to something like `UFS_COMPILER` or `RT_COMPILER` in the future, along with corresponding changes for `NEMS_MACHINE` etc.)
- fixes the `readlink` command in the top-level `build.sh` and in `tests/compile.sh` for macOS (similar to what was done for branch release/public-v1
- remove lines `cp ${PATHRT}/../FV3/ccpp/suites/suite_${CCPP_SUITE}.xml suite_${CCPP_SUITE}.xml` from `tests/fv3_conf/ccpp*.IN`, i.e. no longer copy suite definition files to regression test run directories
- replace GSL drag suite with CIRES UGWP/GFS GWD in `tests/tests/fv3_ccpp_rrfs_v1beta` and `tests/tests/fv3_ccpp_rrfs_v1beta_debug` (cherry-picked from PR ufs-community#205 for branch release/public-v2)
…ry update in dycore (ufs-community#208)

- updates the submodule pointers for fv3atm, GFDL_atmos_cubed_sphere and ccpp-physics for the following changes:
    - bugfixes for CCPP tendencies output (from @grantfirl)
    - global restart reproducibility (from @SMoorthi-emc)
    - bugfix for halo boundary layer update in FV3 dycore (from @chan-hoo)
- moves directory `parm` into directory `tests`
- updates regression test run scripts for HAFS and SAR to copy input data (`diag_table`, `field_table`, initial conditions) from the regression baseline instead of a temporary directory on hera
- note: the following existing diag_table files in the regression test baseline directory `FV3_input_data_gsd` have been updated to match the requirements for running cycled experiments with the GSL physics (@jkhender @joeolson42 FYI)
    - diag_table_gf_thompson
    - diag_table_gsd_noah
    - diag_table_gsd_ruc
    - diag_table_gsd_ruc_diag3d
@DomHeinzeller DomHeinzeller changed the title Update gsd/develop from develop 2020/09/03 Update gsd/develop from develop 2020/10/01 Oct 1, 2020
@DomHeinzeller DomHeinzeller self-requested a review October 2, 2020 01:46
@DomHeinzeller
Copy link

Regression testing on hera.intel using rt_ccpp_gsd.conf: first create new baseline (to verify that all tests run to completion), then verify against it (to ensure that changing the MPI decomposition, changing the number of threads, and restart runs give b4b identical results): all tests pass.

rt_ccpp_gsd_hera_intel_create.log
rt_ccpp_gsd_hera_intel_verify.log

@DomHeinzeller
Copy link

Regression testing on hera.intel against official baseline using rt.conf: the following tests fail as expected (due to changes to GSL physics that have not been merged back to the official baseline), but run to completion. All other tests pass.

fv3_ccpp_rap 040 failed in check_result
fv3_ccpp_hrrr 041 failed in check_result
fv3_ccpp_thompson_no_aero 043 failed in check_result
fv3_ccpp_thompson 042 failed in check_result
fv3_ccpp_gsd 039 failed in check_result
fv3_ccpp_rrfs_v1beta 044 failed in check_result
fv3_ccpp_gsd_debug 053 failed in check_result
fv3_ccpp_rrfs_v1beta_debug 057 failed in check_result
fv3_ccpp_gsd_diag3d_debug 054 failed in check_result
fv3_ccpp_thompson_debug 055 failed in check_result
fv3_ccpp_thompson_no_aero_debug 056 failed in check_result

@DomHeinzeller
Copy link

Regression testing on hera.gnu against official baseline using rt_gnu.conf: the following tests fail as expected (due to changes to GSL physics that have not been merged back to the official baseline), but run to completion. All other tests pass.

fv3_ccpp_thompson 006 failed in check_result
fv3_ccpp_thompson_no_aero 007 failed in check_result
fv3_ccpp_rrfs_v1beta 008 failed in check_result
fv3_ccpp_gsd 005 failed in check_result

@DomHeinzeller
Copy link

@tanyasmirnova I think all five PRs are ready to merge. Please have a close look at the changes in NOAA-GSL/ccpp-physics#53 for module_mp_thompson.F90. Thanks!

@tanyasmirnova
Copy link
Collaborator

@DomHeinzeller I checked module_mp_thompson.F90 - all changes look good.

@DomHeinzeller DomHeinzeller merged commit d45d46b into NOAA-GSL:gsd/develop Oct 2, 2020
SamuelTrahanNOAA pushed a commit to tanyasmirnova/ufs-weather-model that referenced this pull request Mar 24, 2023
… submodule pointer update for ufs-community#462 (ufs-community#1654)

* update FV3 submodule and .gitmodules for testing of 20230313_combo

* turn off cpld_control_p8_faster cheyenne
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants