Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gsd/develop from master 2020/10/01, remove WRFv3.8.1-WRFv4+ switch from Thompson MP #53

Conversation

climbfuji
Copy link

@climbfuji climbfuji commented Sep 4, 2020

Changes in this PR:

  • updates to GFS physics (precision of constants), coupling and surface subcycling from Moorthi
  • update of land surface perturbation code
  • CCPP dependencies in .meta files
  • updates of RRTMGP (CCPP dependencies, cloud sampling)
  • RRTMG cloud overlap generalization from AER
  • correction of CCPP tendencies
  • remove WRFv3.8.1 vs WRFv4+ switch from module_mp_thompson.F90

Associated PRs:

NOAA-GSL/GFDL_atmos_cubed_sphere#8
NOAA-GSL/ccpp-framework#8
#53
NOAA-GSL/fv3atm#49
NOAA-GSL/ufs-weather-model#41

For regression testing information, see NOAA-GSL/ufs-weather-model#41.

SMoorthi-emc and others added 30 commits January 10, 2020 17:44
@DomHeinzeller
Copy link

@tanyasmirnova @hannahcbarnes @joeolson42 @shansun5 FYI - if you have Ben's GitHub account, please tag him as well. All results will change (slightly) because Moorthi declared constants (local to physics schemes etc.) with the correct (double) precision in many schemes.

@DomHeinzeller DomHeinzeller changed the title Update gsd/develop from master 2020/09/03 Update gsd/develop from master 2020/10/01, remove WRFv3.8.1-WRFv4+ switch from Thompson MP Oct 1, 2020
Copy link
Collaborator

@tanyasmirnova tanyasmirnova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dom, I checked the module_mp_thompson.F90, and all your changes look good to me.

@DomHeinzeller DomHeinzeller merged commit 9fae6f3 into NOAA-GSL:gsd/develop Oct 2, 2020
@hannahcbarnes
Copy link

hannahcbarnes commented Oct 2, 2020 via email

@DomHeinzeller
Copy link

Would you like me to use this code base for my retro? I am still working on getting it running correctly, so starting with this code base would not be an issue.

------------- Hannah C Barnes Research Scientist I University of Colorado Boulder Cooperative Institute for Research in Environmental Sciences NOAA/OAR/ESRL/GSL Earth Prediction Advancement Division 325 Broadway, Bldg. DSRC Boulder, CO 80305-3328 (303) 497-6924 [email protected]
On Fri, Oct 2, 2020 at 8:43 AM DomHeinzeller @.***> wrote: Merged #53 <#53> into gsd/develop. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#53 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJG6WGYM67E6TFU76NKFPF3SIXRJNANCNFSM4QYQN4OA .

Sure, I'll send you the top-level hash once it is merged.

@climbfuji climbfuji deleted the update_gsd_develop_from_master_20200903 branch June 27, 2022 03:28
SamuelTrahanNOAA pushed a commit to tanyasmirnova/ccpp-physics that referenced this pull request Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants