Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Depend on signed version of Elmah #3609

Merged
merged 2 commits into from
Mar 2, 2017
Merged

Depend on signed version of Elmah #3609

merged 2 commits into from
Mar 2, 2017

Conversation

joelverhagen
Copy link
Member

@joelverhagen joelverhagen commented Mar 2, 2017

  1. Change from elmah.sqlserver to elmah.sqlserver.strongname
  2. Change from elmah to elmah.strongname
  3. Change from elmah.corelibrary to elmah.corelibrary.strongname
  4. Remove Elmah.Contrib.Mvc and copy the source (it's a single class from a StackOverflow answer).

This means that dashboard can remove its NuGetGallery dependency and just depend on NuGetGallery.Core (which can not be strong name signed).

Verification steps:

  1. Generate exception with SQL Server error sink.
  2. Generate exception with Azure Table Storage error sink.
  3. Make sure the admin error page works.
  4. Make sure non-admins cannot access the error page.

@joelverhagen joelverhagen merged commit 3f97e7b into dev Mar 2, 2017
@joelverhagen joelverhagen deleted the jver-signedelmah branch March 2, 2017 20:20
jozefizso added a commit to goit/NuGetGallery that referenced this pull request Apr 20, 2017
…7.03.27

* tag 'v2017.03.27': (205 commits)
  Revert UpdateIsLatest optimistic concurrency changes (NuGet#3707)
  UpdateIsLatest concurrent unlist fix (NuGet#3695)
  Change telemetry time to use correct format (NuGet#3690)
  Fix typo of "publically" (NuGet#3636)
  Fix regression (NuGet#3667)
  Add credential to Register and RequestPasswordReset audits (NuGet#3666)
  Functional test for temp keys (NuGet#3664)
  Telemetry for temp keys (NuGet#3662)
  Temp keys implementation (NuGet#3563) (NuGet#3646)
  Extracting code: single type per file (NuGet#3644)
  Telemetry for package push (NuGet#3649)
  Upgrade to NuGet.* v4.0.0 dependencies (NuGet#3643)
  Fix concurrent push test by disabling search hijacking on feed (NuGet#3641)
  Fixing Package Description truncation (NuGet#3638)
  Fix Microsoft Account removal (NuGet#3639)
  Send e-mail when a new API key is created (NuGet#3634)
  IsLatest Fix: wrong connection string passed to retry context (NuGet#3632)
  Update WindowsAzure.Storage to 7.0.0 (NuGet#3633)
  Depend on signed version of Elmah (NuGet#3609)
  Move AzureEntityList and TableErrorLog to NuGetGallery.Core (NuGet#3607)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants