Telemetry for package push #3649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skofman1
requested review from
xavierdecoster,
shishirx34,
ryuyu,
dtivel,
chenriksson,
cristinamanum and
scottbommarito
chenriksson
approved these changes
Mar 14, 2017
| telemetryProperties.Add(CallContext, callContext); | ||
| telemetryProperties.Add(IsEnabled, $"{isEnabled}"); | ||
|
|
||
| telemetryProperties.Add(IsAllowed, isAllowed.ToString()); |
There was a problem hiding this comment.
$"{isAllowed}" for consistency?
src/NuGetGallery/ExtensionMethods.cs
Outdated
|
|
||
| isScoped = !ScopeEvaluator.IsEmptyScopeClaim(scopeClaim); | ||
| return authenticationMethodClaim; | ||
| } |
There was a problem hiding this comment.
Wondering if this would be better as 2 APIs. Seems a bit overloaded in returning a second value as an out param.
jozefizso
added a commit
to goit/NuGetGallery
that referenced
this pull request
Apr 20, 2017
…7.03.27 * tag 'v2017.03.27': (205 commits) Revert UpdateIsLatest optimistic concurrency changes (NuGet#3707) UpdateIsLatest concurrent unlist fix (NuGet#3695) Change telemetry time to use correct format (NuGet#3690) Fix typo of "publically" (NuGet#3636) Fix regression (NuGet#3667) Add credential to Register and RequestPasswordReset audits (NuGet#3666) Functional test for temp keys (NuGet#3664) Telemetry for temp keys (NuGet#3662) Temp keys implementation (NuGet#3563) (NuGet#3646) Extracting code: single type per file (NuGet#3644) Telemetry for package push (NuGet#3649) Upgrade to NuGet.* v4.0.0 dependencies (NuGet#3643) Fix concurrent push test by disabling search hijacking on feed (NuGet#3641) Fixing Package Description truncation (NuGet#3638) Fix Microsoft Account removal (NuGet#3639) Send e-mail when a new API key is created (NuGet#3634) IsLatest Fix: wrong connection string passed to retry context (NuGet#3632) Update WindowsAzure.Storage to 7.0.0 (NuGet#3633) Depend on signed version of Elmah (NuGet#3609) Move AzureEntityList and TableErrorLog to NuGetGallery.Core (NuGet#3607) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.