Upgrade to NuGet.* v4.0.0 dependencies #3643
Conversation
…ft.json to vLatest
… longer be copied in the gallery code base
|
I have a PR changing gallery to .NET 4.6.2.. the merge conflicts I'm going to get break my ❤️ |
| @@ -46,7 +43,7 @@ private static IEnumerable<ValidationResult> ValidateCore(PackageMetadata packag | |||
| } | |||
| else | |||
| { | |||
| if (packageMetadata.Id.Length > MaxPackageIdLength) | |||
| if (packageMetadata.Id.Length > NuGet.Packaging.PackageIdValidator.MaxPackageIdLength) | |||
There was a problem hiding this comment.
One thing to note--(last time I checked) the gallery accepts nupkgs with up to a 128 characters in the id. Probably good to switch this to use this here but I question why we have this validating against 100 characters when the gallery accepts 128.
There was a problem hiding this comment.
@scottbommarito any pointers to where in the code base we accept 128 chars? I did not change the value in this PR, so perhaps we should log a separate issue to track that one.
There was a problem hiding this comment.
I don't know if you need to change this, but using the constant was part of #3305 which was reverted.
There was a problem hiding this comment.
Interesting. I think we should definitely look into that some day. If I understand correctly, the gallery db is more forgiving than the server and client validation (the other way around would 've been worse though). Will leave it in as part of this PR, as I believe the server should leverage and align with the client validation.
There was a problem hiding this comment.
Tracked in issue #3647
| <section name="entityFramework" type="System.Data.Entity.Internal.ConfigFile.EntityFrameworkSection, EntityFramework, Version=6.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089" requirePermission="false" /> | ||
| </configSections> | ||
| <!-- For more information on Entity Framework configuration, visit http://go.microsoft.com/fwlink/?LinkID=237468 --></configSections> |
There was a problem hiding this comment.
Did this comment get moved automatically?
Huge nit but I prefer where it was before.
There was a problem hiding this comment.
Yes, nuget did this 🙌
There was a problem hiding this comment.
Reverted this auto-change in 4b62421
…7.03.27 * tag 'v2017.03.27': (205 commits) Revert UpdateIsLatest optimistic concurrency changes (NuGet#3707) UpdateIsLatest concurrent unlist fix (NuGet#3695) Change telemetry time to use correct format (NuGet#3690) Fix typo of "publically" (NuGet#3636) Fix regression (NuGet#3667) Add credential to Register and RequestPasswordReset audits (NuGet#3666) Functional test for temp keys (NuGet#3664) Telemetry for temp keys (NuGet#3662) Temp keys implementation (NuGet#3563) (NuGet#3646) Extracting code: single type per file (NuGet#3644) Telemetry for package push (NuGet#3649) Upgrade to NuGet.* v4.0.0 dependencies (NuGet#3643) Fix concurrent push test by disabling search hijacking on feed (NuGet#3641) Fixing Package Description truncation (NuGet#3638) Fix Microsoft Account removal (NuGet#3639) Send e-mail when a new API key is created (NuGet#3634) IsLatest Fix: wrong connection string passed to retry context (NuGet#3632) Update WindowsAzure.Storage to 7.0.0 (NuGet#3633) Depend on signed version of Elmah (NuGet#3609) Move AzureEntityList and TableErrorLog to NuGetGallery.Core (NuGet#3607) ...
This PR
NuGet.*dependencies to version 4.0.0MoqandNewtonsoft.Jsondependencies to vLatestNuGet.Packaging.PackageIdValidator.MaxPackageIdLengthinstead of copy/paste + #sadpanda comment in the gallery code baseThis PR will also facilitate other validation improvements that are required for semver2 work (and didn't want to pollute those PRs with this upgrade).