[RFC4_dev] Address code review comments #1826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…log functionality
…hgridshift/vgridshift/deformation structures
…stward correction' in the CTable2/NTv1/NTv2 backends
…at are going to be used by later commit
…grid. Used for French NTF to RGF93 transformation using gr3df97a.tif grid
…n switching between (sub)grids (fixes OSGeo#1663) Given in.txt with 53.999759140 5.144478208 252.6995 Before the fix, cct -t 0 -d 4 +proj=pipeline +step +proj=axisswap +order=2,1,3,4 +step +proj=hgridshift +inv +grids=rdtrans2018.gsb +step +proj=vgridshift +grids=naptrans2018.gtx +step +proj=sterea +lat_0=52.156160556 +lon_0=5.387638889 +k=0.9999079 +x_0=155000 +y_0=463000 +ellps=bessel in.txt returned: 139079.8814 668306.0302 212.1724 0.0000 It now returns: 139079.8850 668306.0458 212.1724 0.0000 which meets with the 1mm accuracy the expected result of test point ``` 30010049 53.999759140 5.144478208 252.6995 139079.8850 668306.0460 212.1723 ```
…value(), and test
…_network(ctx, true)
…ilable, and networking enabled
- Move content of legacy apply_gridshift.cpp and apply_vgridshift.cpp in grids.cpp - Rename nad_ functions to pj_hgrid_ - Rename internal proj_hgrid_/proj_vgrid_ functions to pj_
rouault
force-pushed
the
rfc4_code_review
branch
from
fc42d9b
to
eafeb61
Compare
rouault
force-pushed
the
rfc4_code_review
branch
2 times, most recently
from
3dd85f2
to
d279de5
Compare
rouault
force-pushed
the
rfc4_code_review
branch
from
d279de5
to
237296b
Compare
mwtoews
reviewed
Jan 7, 2020
Thanks. Done per 8821b35 |
…nitialized variables
rouault
force-pushed
the
rfc4_code_review
branch
from
5fb9a3d
to
90b6685
Compare
|
Any objection to merge this ? |
No. In this PR you've taken care of all the things we didn't like about the earlier PR's, so I think this should be fine to merge without further reviews :-) |
|
Actually the title of the PR is a bit misleading. It started with code review-only changes, but commits starting with "pj_bilinear_interpolation_three_samples(): fix MSVC warning" are about other fixes & additions |
|
Okay, I see if I can find the time to look at those commits during the weekend. It'd be nice to get RFC4 stuff fully merge soon. |
kbevers
reviewed
Jan 18, 2020
kbevers
reviewed
Jan 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of PR #1817. Commits specific to this one start at "Grid refactoring: address review comments of #1777 "