[RFC4_dev] Use Win32 Unicode APIs and expect all strings to be UTF-8 (fixes #1765) #1839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move content of legacy apply_gridshift.cpp and apply_vgridshift.cpp in grids.cpp - Rename nad_ functions to pj_hgrid_ - Rename internal proj_hgrid_/proj_vgrid_ functions to pj_
…nitialized variables
…o#1765) For backward compatibility, if PROJ_LIB content is found to be not UTF-8 or pointing to a non existing directory, then an attempt at interpretating it in the ANSI page encoding is done. proj_context_set_search_paths() now assumes strings to be in UTF-8, and functions returning paths will also return values in UTF-8.
rouault
force-pushed
the
rfc4_utf8
branch
6 times, most recently
from
d73a749
to
b8b6f74
Compare
rouault
force-pushed
the
rfc4_utf8
branch
3 times, most recently
from
a754945
to
929f37b
Compare
…exclusive of new option +grids
rouault
force-pushed
the
rfc4_utf8
branch
4 times, most recently
from
7ae37ee
to
81a6585
Compare
kbevers
reviewed
Jan 18, 2020
There was a problem hiding this comment.
The bulk of this PR is the unicode stuff which isn't something I feel comfortable reviewing. I hope someone else can review this.
I appreciate that a replacement for the proj_api.h fileAPI has been added to proj.h. On a functional level I am also happy to see unicode support added!
It is largely inspired from what is used in GDAL: UTF-8 <--> widechar conversions and use of Win32 Widechar File APIs |
|
@hobu Want to give that a review ? |
hobu
reviewed
Jan 20, 2020
rouault
added a commit
to rouault/PROJ
that referenced
this pull request
Jan 20, 2020
|
Unless someone has further comments, I'll merge that tomorrow |
mwtoews
reviewed
Jan 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not completely RFC4 specific but proper unicode support for Windows is now really needed given all the file manipulations we do.
continuation of PR #1826, starting with commit f6c4241