v19.4.19

[fballiano]

Overview

This is a maintanance release with small bugfixes, code cleanup, documentation improvements and a better overall PHPStan coverage.
We're also bumping the minimum required PHP version to 7.3 with intl extension enabled.
Our source code finally has a much better "copyright" section, to thank all the team that is contributing to this beautiful project.

Important things you should check before upgrading

This release requires PHP 7.3 with intl extension, do not upgrade if your system doesn't match this requirement.

What's Changed

• Fixed whitespace for docblocks by @fballiano in Fixed whitespace for docblocks #2550
• Remove redundant polyfill code for error reporting constants by @elidrissidev in Remove redundant polyfill code for error reporting constants #2555
• Fixed whitespace for docblocks by @fballiano in Fixed whitespace for docblocks #2556
• Some CSS fixes to OpenMage adminhtml theme by @sreichel in Some CSS fixes to OpenMage adminhtml theme #2422
• Fixed whitespace for docblocks by @fballiano in Fixed whitespace for docblocks #2558
• Set default width for grid datetime columns, ref Inconsistent column width in Backend grids. #2239 by @sreichel in Set default width for grid datetime columns, ref #2239 #2544
• Removed PHP 5.3 compatibility code from Mage_Adminhtml_Model_System_Config_Backend_Locale_Timezone by @fballiano in Removed PHP 5.3 compatibility code from Mage_Adminhtml_Model_System_Config_Backend_Locale_Timezone #2563
• Added info about targetNamespace change in README by @fballiano in Added info about targetNamespace change in README #2559
• Removed unused controller Mage_Shipping_ShippingController by @fballiano in Removed unused controller Mage_Shipping_ShippingController #2564
• phpstan: fixed calls on Varien_Object/Mage_Core_Model_Abstract by @sreichel in phpstan: fixed calls on Varien_Object/Mage_Core_Model_Abstract #2565
• Ignore scss-cache and .phar files in .gitignore by @sreichel in Ignore scss-cache and .phar files in .gitignore #2566
• Changed boolean/integer to bool/int in docs by @sreichel in Changed boolean/integer to bool/int in docs #2567
• Fixed whitespace for docblocks by @fballiano in Fixed whitespace for docblocks #2562
• An Exception is thrown and logged if file is not found while merging by @fballiano in An Exception is thrown and logged if file is not found while merging #2445
• Fixed PHPStan error with Mage_Catalog_Model_Resource_Product_Option_Collection by @fballiano in Fixed PHPStan error with Mage_Catalog_Model_Resource_Product_Option_Collection #2572
• Make php7.3 minimum requirement by @sreichel in Make php7.3 minimum requirement #2413
• Added missing css.map file by @sreichel in Added missing css.map file #2573
• Added php-extension "intl" as requirement, updated composer by @sreichel in Added php-extension "intl" as requirement, updated composer  #2437
• Delete Mage_AmazonPayments.csv by @elidrissidev in Delete Mage_AmazonPayments.csv #2579
• Update label for system/csrf/use_form_key config by @elidrissidev in Update label for system/csrf/use_form_key config #2578
• Refactoring: Replace dirname(FILE) With Corresponding Constant by @Sdfendor in Refactoring: Replace dirname(__FILE__) With Corresponding Constant #2582
• Fixed some docs for phpdocumentor by @sreichel in Fixed some docs for phpdocumentor #2577
• phpstan: added some return statements to match parent class or interface by @sreichel in phpstan: added some return statements to match parent class or interface #2574
• phpstan: return type fixes by @sreichel in phpstan: return type fixes #2587
• Use null coalescing operator by @sreichel in Use null coalescing operator #2543
• Updated phpstan experimental by @sreichel in Updated phpstan experimental #2589
• Fix Phpdoc Typos in Various Files by @Sdfendor in Fix Phpdoc Typos in Various Files #2591
• phpstan: fixed "Access to an undefined property" by @sreichel in phpstan: fixed "Access to an undefined property" #2554
• Strip null bytes from strings and filter conditions. by @colinmollenhour in Strip null bytes from strings and filter conditions. #1430
• Fixed phpstan-workflow by @sreichel in Fixed phpstan-workflow #2593
• Some fixes for phpdocs by @sreichel in Some fixes for phpdocs #2588
• Removed Mage_GoogleBase.csv by @sreichel in Removed Mage_GoogleBase.csv #2599
• Better admin/config validation for allowed currencies by @sreichel in Better admin/config validation for allowed currencies #2597
• Fix admin grid filter, ref Strip null bytes from strings and filter conditions. #1430 by @sreichel in Fix admin grid filter, ref #1430 #2602
• [backport] Aggregate most viewed products report daily via a Cron job (Aggregate most viewed products report daily via a Cron job #1829) by @sreichel in [backport] Aggregate most viewed products report daily via a Cron job (#1829) #2610
• Update deprecated using ${var} in lib/Zend by @sreichel in Update deprecated using ${var} in lib/Zend #2611
• Fix integers being cast to decimal in some particular cases by @digitalpianism in Fix integers being cast to decimal in some particular cases #1198
• phpstan: fixes for Mage_Catalog_Model_Product_Type_Abstract by @sreichel in phpstan: fixes for Mage_Catalog_Model_Product_Type_Abstract #2605
• phpdocs: Undefined methods by @sreichel in phpdocs: Undefined methods #2613
• Downgraded composer dependencies to also fit php7.3 by @sreichel in Downgraded composer dependencies to also fit php7.3 #2576
• Added two indexes on sales_flat_order and sales_flat_order_item tables by @fballiano in Added two indexes on sales_flat_order and sales_flat_order_item tables #2447
• Phpdocs/phpstan update by @sreichel in Phpdocs/phpstan update #2596
• Replace Date Format String Literals With Existing Constants by @Sdfendor in Replace Date Format String Literals With Existing Constants #2592
• [PHP 8.1] Fix passing null to preg_split limit param by @elidrissidev in [PHP 8.1] Fix passing null to preg_split limit param #2616
• Updated github workflow by @sreichel in Updated github workflow #2608
• Updated README by @sreichel in Updated README #2618
• Fixed detect changes in custom options section (product edit) by @fballiano in Fixed detect changes in custom options section (product edit) #2444
• Add/Remove mark when region/zip is required by @luigifab in Add/Remove mark when region/zip is required #2149
• Optimize EAV collections by @Sekiphp in Optimize EAV collections #911
• Convert Exception to Throwable in Mage_Core_Block_Template. by @kiatng in Convert Exception to Throwable in Mage_Core_Block_Template. #2623
• Added css class for sorted columns by @sreichel in Added css class for sorted columns #2604
• Improvements in cron scripts by @fballiano in Improvements in cron scripts #2380
• Fixed javascript error on adminhtml login page caused by Add/Remove mark when region/zip is required #2149 by @fballiano in Fixed javascript error on adminhtml login page caused by #2149 #2624
• Fixed bug caused by phpstan: fixes for Mage_Catalog_Model_Product_Type_Abstract #2605 by @fballiano in Fixed bug caused by #2605 #2625
• Fix workflow badges in README by @elidrissidev in Fix workflow badges in README #2626
• Update hardcoded credit card message in checkout by @elidrissidev in Update hardcoded credit card message in checkout #2628
• bugfix + add module names to helper by @sreichel in bugfix + add module names to helper #2617
• Get catalog search result collection from engine by @elidrissidev in Get catalog search result collection from engine #2634
• Add PHP dependencies security check workflow by @elidrissidev in Add PHP dependencies security check workflow #2639
• [security-workflow] Fixed cron syntax by @sreichel in [security-workflow] Fixed cron syntax #2640
• Add OpenMage Contributors Copyright by @justinbeaty in Add OpenMage Contributors Copyright #2295
• docs: added ddev snippets by @sreichel in docs: added ddev snippets #2575
• Only run workflows when relevant files change by @elidrissidev in Only run workflows when relevant files change #2641
• Add back notification popup severity icons URL by @elidrissidev in Add back notification popup severity icons URL #2633
• Fixes issue Remove magento validator jpeg force quality #475, reduce reprocessed jpeg image file size by defaulting image quality to 85% by @kiatng in Fixes issue #475, reduce reprocessed jpeg image file size by defaulting image quality to 85% #2629
• Prevent from editing a non-editable Order by @elidrissidev in Prevent from editing a non-editable Order #2632
• Allow automatic full invoice from API by @luigifab in Allow automatic full invoice from API #2393
• Add check if array key exists before use it by @przemyslaw-p in Add check if array key exists before use it #2649
• Reload admin ACL by @luigifab in Reload admin ACL #1714
• Fixed Mage_Catalog_Model_Product_Status::addSaleableFilterToCollection() does nothing by @fballiano in Fixed Mage_Catalog_Model_Product_Status::addSaleableFilterToCollection() does nothing #2603
• Reindex EAV values only for active storeviews by @fballiano in Reindex EAV values only for active storeviews #2651
• Check if remote storage is enabled before saving local file by @elidrissidev in Check if remote storage is enabled before saving local file #2627
• Phpstan: fixed return types (docs only) by @sreichel in Phpstan: fixed return types (docs only) #2636
• Cast getLoadingTimeout() to int in template by @sreichel in Cast getLoadingTimeout() to int in template #2661
• Fixes Product flat tables broken, ref #2603 #2658 by @sreichel in Fixes #2658 #2662
• Re-added composer validation to github workflow by @sreichel in Re-added composer validation to github workflow #2667
• Fix bug on clonePosition() in prototype.js. by @kiatng in Fix bug on clonePosition() in prototype.js. #2669
• Fixes phpunit-workflow by @sreichel in Fixes phpunit-workflow #2672
• Reduce getId calls by @luigifab in Reduce getId calls #2677
• Allow to save configuration without fields by @luigifab in Allow to save configuration without fields #2679
• Do not crash when creditmemo does not exist by @luigifab in Do not crash when creditmemo does not exist #2684
• Fix esi parsing with turpentine by @luigifab in Fixed ESI parsing error with turpentine #2682
• Remove try catch throw by @luigifab in Remove try catch throw #2676
• Version bump in preparation for release by @fballiano in Version bump in preparation for release #2688

Full Changelog: v19.4.18...v19.4.19

---

This discussion was created from the release v19.4.19.