Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(HPM): move HPMs from utils to utility repo #3631

Merged
merged 1 commit into from
Sep 24, 2024
Merged

refactor(HPM): move HPMs from utils to utility repo #3631

merged 1 commit into from
Sep 24, 2024

Conversation

yu-yake2002
Copy link
Contributor

Because HPMs will be used in Coupled L2 as well, delete PerfCounterUtils.scala in Xiangshan and create HardwarePerfMonitor.scala in Utility.
See also Pull Request in CoupledL2.

@eastonman
Copy link
Member

Q: Is anyone interested in refactoring the code below?
https://github.com/OpenXiangShan/Utility/blob/342e0ad98bf24bf550f4d44099bd64875145d07c/src/main/scala/utility/HardwarePerfMonitor.scala#L34
This line of code generates 600-ish ungated registers in frontend.

@XiangShanRobot
Copy link

[Generated by IPC robot]
commit: ecd2e6e

commit astar copy_and_run coremark gcc gromacs lbm linux mcf microbench milc namd povray wrf xalancbmk
ecd2e6e 1.934 0.451 2.704 1.194 2.812 2.465 2.400 0.913 1.401 1.626 3.421 2.758 2.429 3.271

master branch:

commit astar copy_and_run coremark gcc gromacs lbm linux mcf microbench milc namd povray wrf xalancbmk
fa9d630 1.934 0.451 2.704 1.194 2.812 2.465 2.400 0.913 1.401 1.626 3.415 2.758 2.429 3.271
26175c3 1.934 0.451 2.704 1.194 2.812 2.465 2.400 0.913 1.401 1.626 3.415 2.758 2.429 3.271
d6b32cb 1.934 0.451 2.704 1.194 2.812 2.465 2.400 0.918 1.401 1.609 3.419 2.753 2.429 3.275
478bf92 0.451 2.704 1.194 2.812 2.465 2.400 0.918 1.401 1.609 3.419 2.753 3.275
ad415ae 1.934 0.450 2.695 1.192 2.812 2.465 2.399 0.918 1.397 1.609 3.424 2.761 2.429 3.275
5860cb7 1.934 0.450 2.695 1.192 2.812 2.465 2.399 0.918 1.397 1.609 3.424 2.761 2.429 3.275
45def85 1.934 0.450 2.695 1.192 2.812 2.465 2.399 0.918 1.397 1.609 3.424 2.761 2.429 3.275
a4c587d 1.934 0.450 2.695 1.192 2.812 2.465 2.399 0.918 1.397 1.609 3.424 2.761 2.429 3.275
cb36ac0 1.934 0.450 2.695 1.192 2.812 2.465 2.399 0.918 1.397 1.609 3.424 2.761 2.429 3.275
9402431 1.934 0.450 2.695 1.192 2.812 2.465 2.399 0.918 1.397 1.609 3.424 2.761 2.429 3.275

@Tang-Haojin
Copy link
Member

Q: Is anyone interested in refactoring the code below?

https://github.com/OpenXiangShan/Utility/blob/342e0ad98bf24bf550f4d44099bd64875145d07c/src/main/scala/utility/HardwarePerfMonitor.scala#L34

This line of code generates 600-ish ungated registers in frontend.

Mark

@Tang-Haojin Tang-Haojin merged commit 44f2941 into OpenXiangShan:master Sep 24, 2024
8 checks passed
@yu-yake2002 yu-yake2002 mentioned this pull request Sep 24, 2024
Merged
@yu-yake2002 yu-yake2002 mentioned this pull request Oct 9, 2024
Merged
Ivyfeather pushed a commit that referenced this pull request Oct 10, 2024
@yu-yake2002
feat(HPM): enable HPMs in CoupledL2 and print them (#3708)
8bb30a5 
* Bump CoupledL2 and connect perf events.
* Update the number of HPMs
* Detail names of HPM can be printed now. The previous implementation
has been removed in
[#3631](#3631).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tang-Haojin Tang-Haojin Tang-Haojin approved these changes

@linjuanZ linjuanZ linjuanZ approved these changes

@happy-lx happy-lx Awaiting requested review from happy-lx happy-lx is a code owner

@bosscharlie bosscharlie Awaiting requested review from bosscharlie bosscharlie is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yu-yake2002 @eastonman @XiangShanRobot @Tang-Haojin @linjuanZ