December Schema Update #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the notion of a building part. Both building footprints and building parts share in some shape definitions. These are pulled out in a common defs.yaml file which are shared by buildings (footprints) and parts. Validated/tested with the test.sh script
Was missing the building id in the part example
jenningsanderson
requested review from
RobSoetewey-TomTom,
vcschapp and
jwass
vcschapp
reviewed
Dec 6, 2023
vcschapp
reviewed
Dec 6, 2023
This commit replaces all the scrappy diagrams I created for the detailed Transportation theme documentation pages with slightly improved versions that follow the Overture Maps Foundation's colour palette. Thanks to The Linux Foundation graphics team and LF's nanwar@ for this beautiful improvement!
Add footway to road class enum
Improve Transportation diagrams with dark/light theme and Overture color palette
…afeteria-spelling-fix fix: spelling of cafeteria
Fix type maxiumum->maximum on linearlyReferencedPosition
RobSoetewey-TomTom
approved these changes
Dec 13, 2023
DavidKarlas
approved these changes
Dec 13, 2023
vcschapp
reviewed
Dec 13, 2023
There was a problem hiding this comment.
Ship it!
.-.
( (
`-'
. ,- To the Moon Alice !
.'.
|o|
.'o'.
|.-.|
' '
( )
)
( )
____
.-'""p 8o""`-.
.-'8888P'Y.`Y[ ' `-.
,']88888b.J8oo_ '`.
,' ,88888888888[" Y`.
/ 8888888888P Y8\
/ Y8888888P' ]88\
: `Y88' P `888:
: Y8.oP '- > Y88:
| `Yb __ `'|
: `'d8888bo. :
: d88888888ooo. ;
\ Y88888888888P /
\ `Y88888888P /
`. d88888P' ,'
`. 888PP' ,'
`-. d8P' ,-' -CJ-
`-.,,_'__,,.-'
AleksandraDebicka-TomTom
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standing PR for December Schema Release (version 0.7.0)
Preview: https://dfhx9f55j8eg5.cloudfront.net/latest/