Consolidated community contributions #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add explicit JSON for `ContactMethod`: * `ID` * `Label` * `Address` * `Type` * Add field for `ContactMethod`: * `Summary` * Add explicit JSON for `NotificationRule`: * `ID` * `Urgency` * `Type` * Add explicit JSON for `User`: * `InvitationSent` * Correct explicit JSON for `User`: * `timezone` to `time_zone` * Add fields for `User`: * `Type` * `Summary`
* Add fields for `Vendor`: * `AlertCreationDefault` * `AlertCreationEditable` * `IsPDCEF` No vendor endpoint in the CLI so hard to demonstrate this one in comparison to `master`. Although fields are not listed in the Response Schema in documentation, the actual endpoint does: ``` curl -X GET --header 'Accept: application/vnd.pagerduty+json;version=2' --header 'Authorization: Token token=changeme' 'https://api.pagerduty.com/vendors' ```
* Adding struct for `AlertCounts` * Adding struct for `ResolveReason` * Adding fields to `Incident`: * `Title` * `Description` * `ImpactedServices` * `AlertCounts` * `IsMergeable` * `Importance` * `ResolveReason`
Add the ability to list a user's contact methods
- added type AlertCounts - added type Priority - added type ResolveReason - added type IncidentBody - added fields to type Incident: - Title - Priority - ResolveReason - AlertCounts - Body
Allows for merging of incidents as follows:
incidents := make([]string, 3)
incidents[0] = "PXXXXXX"
incidents[1] = "PYYYYYY"
incidents[2] = "PZZZZZZ"
first := incidents[0]
rest := incidents[1:]
tomerge := make([]pagerduty.APIObject, 0)
for i := range rest {
inc := pagerduty.Incident{
APIObject: pagerduty.APIObject{
ID: rest[i],
Type: "incident_reference",
},
}
tomerge = append(tomerge, inc)
}
result := client.MergeIncidents(email, first, tomerge)
…flect use add From header which is required for CreateMaintenanceWindow calls add CreateMaintenanceWindowOptions struct to match general style
I believe go expects the directory layout to be $GOPATH/src https://github.com/golang/go/wiki/GOPATH
This gives the ability for CLI users to put new events on the v2 queue to trigger, acknowledge and resolve incidents.
As the panic function will kill the program, the else statement is useless.
…rduty into domudall-feature/struct-fix-user
… into domudall-feature/vendor-cli
…gerduty into domudall-feature/struct-fix-vendor
…duty into atomicules-merge-incidents-opt1
…hnl/go-pagerduty into wdhnl-feature/fix-create-maintenance-window
This allows us to preserve compatibility for the time being, should be unified with `CreateMaintenanceWindow` for next major revision.
…l/go-pagerduty into wdhnl-feature/fix-create-incident-options
…to monzo-get-contact-method
…ty into DennyLoko-fix-incident-struct
…nto philnielsen-events-v2-cli
…oullivaneuh-patch-1
|
Will have a change up shortly to fix the Also another reason it might be useful to rethink how we're building the CLI -- at the very least adding go modules support and adjusting our build steps. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch incorporates a bunch of old un-merged PRs from upstream in an attempt to fast-track clearing out the current backlog, specifically:
It doesn't attempt to merge, due to potential complexity:
And skips the following as it was picked up as part of pulling in the above merged PRs:
Given the number of contributions being pulled in we might be introducing some inconsistencies, but we already have a number of them in the client library -- a subsequent pass would be good for further cleanup.