Adding new fields to Vendor #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add fields for `Vendor`: * `AlertCreationDefault` * `AlertCreationEditable` * `IsPDCEF` No vendor endpoint in the CLI so hard to demonstrate this one in comparison to `master`. Although fields are not listed in the Response Schema in documentation, the actual endpoint does: ``` curl -X GET --header 'Accept: application/vnd.pagerduty+json;version=2' --header 'Authorization: Token token=changeme' 'https://api.pagerduty.com/vendors' ```
dobs
added a commit
to dobs/go-pagerduty
that referenced
this pull request
Mar 19, 2019
This branch incorporates a bunch of old un-merged PRs from upstream, specifically: - PagerDuty#72 - PagerDuty#73 - PagerDuty#74 - PagerDuty#75 - PagerDuty#78 - PagerDuty#91 - PagerDuty#93 - PagerDuty#97 - PagerDuty#104 - PagerDuty#106 - PagerDuty#108 - PagerDuty#113 - PagerDuty#114 - PagerDuty#126 - PagerDuty#127 - PagerDuty#130 - PagerDuty#132 - PagerDuty#137 - PagerDuty#138 - PagerDuty#140 - PagerDuty#143 It doesn't attempt to merge, due to potential complexity: - PagerDuty#48 - PagerDuty#99 - PagerDuty#134 And skips the following as it was picked up as part of pulling in the above merged PRs: - PagerDuty#133 Will have subsequent PRs for cleanup, specifically: - Reducing duplicate code. - Standardizing response and error handling. Followed by more janitorial and refactor-oriented changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vendor:AlertCreationDefaultAlertCreationEditableIsPDCEFNo vendor endpoint in the CLI (see #73) so hard to demonstrate this one in comparison to
master. Although fields are not listed in the Response Schema in documentation, the actual endpoint does: