Augment Channel for other possible fields

[jakedavis]

Hi!

We've found ourselves really wanting the "Details" from the channel field within the first trigger log entry, and noticed that the struct in this library doesn't include it as a field. I'm hoping we can augment that struct so we can access it within our project. The commit contains a bit more context as well.

I couldn't find much documentation about channels, so I don't know if this will cause any bad effects, but it appears to me that these four fields are consistent.

Apologies for the little whitespace change; I can recommit without if need be. My go linting tool does that automatically.

Thanks for reviewing!

[jakedavis]

I managed to find some more information from the v1 API documentation, and it looks like I've configured it specifically for the Web Trigger type:

https://v1.developer.pagerduty.com/documentation/rest/log_entries/show

So it sounds like this PR won't work as-is, but maybe I can instead change Channel to be a *json.RawMessage instead?

[ranjib]

@jakedavis that is exactly what i am thinking. We would be loosing the known "type" entry in this route, i tried this without success

type Channel struct{
    json.RawMessage
    Type string `json:"type"`
}

[atomicules]

I'm newish to Go, but have had to tweak this to pull out a detail I'm interested in. I.e. I've ended up with:

// Channel is the means by which the action was carried out.
type Channel struct {
	Type string
	Details struct {
		Check struct {
			FieldIWant string `json:"field_I_want"`
		} `json:"check"`
	} `json:"details"`
}

Hard to see how that could be made flexible enough for everyone using structs and json. Maybe https://github.com/tidwall/gjson would be better... but I haven't investigated yet.

[stmcallister]

We completely agree this should be addressed, but as mentioned above not with this implementation. Going to close this now, but would welcome additional ideas going forward.