yaml: Add read_archive Options struct (currently a no-op) #13537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This paves the way for dealing with parser options in a future commit. Thread the Options through the Serialize/Visit flow but don't use it for anything yet. Rename ReportMissingYaml to ReportError to avoid being overly specific; this was already used for error messages beyond just missing stuff. While we're here, also import the unit test with helpful comments and extracting some literal strings into named variables.
|
+@ggould-tri for feature review, please. |
|
@drake-jenkins-bot linux-focal-gcc-bazel-experimental-release please |
ggould-tri
reviewed
Jun 11, 2020
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1.
Reviewable status: needs at least two assigned reviewers
|
+@sammy-tri for platform review per schedule, please. |
sammy-tri
reviewed
Jun 11, 2020
There was a problem hiding this comment.
Reviewable status:
complete! all discussions resolved, LGTM from assignees ggould-tri(platform),sammy-tri(platform) (waiting on @sammy-tri)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This paves the way for dealing with parser options in a future commit.
Thread the Options through the Serialize/Visit flow but don't use it for anything yet.
Rename ReportMissingYaml to ReportError to avoid being overly specific; this was already used for error messages beyond just missing stuff.
While we're here, also import the unit test with helpful comments and extracting some literal strings into named variables.
This builds on #13533 and is a prerequisite for #13532 towards #13251.
This change is