Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEW][ENTERPRISE] Support for custom Livechat registration form fields #17581

Conversation

renatobecker
Copy link
Contributor

@renatobecker renatobecker commented May 8, 2020

Related to RocketChat/Rocket.Chat.Livechat#407

This implementation adds new properties to the Livechat custom fields.
These changes will impact both Livechat Registration Form and Visitor Edit Panel.

For the the Livechat Widget, only fields with the scope = visitor, visibility = visible and public = true, will be shared.

The new fields supported(Enterprise edition) are described below:

  • type (text | select)
  • required (true | false)
  • options (used on Select components | optional)
  • defaultValue (optional)
  • public (true | false)

Screen Shot 2020-05-12 at 18 53 06

On the widget side, it will look like this(Now displaying validation errors):

Screen Shot 2020-05-12 at 12 10 33

Once the Visitor is registered and starts a new conversation, the custom fields information will be displayed on the Omnichannel Room Info panel as you can see here:

Screen Shot 2020-05-08 at 17 29 04

In addition, the fields with the type = select will be rendered properly on the Visitor Edit panel.

Screen Shot 2020-05-12 at 19 00 36

@renatobecker renatobecker added this to the 3.3.0 milestone May 8, 2020
@renatobecker renatobecker changed the title [NEW][ENTERPRISE] Support for custom Livechat registration form fields [NEW] [ENTERPRISE] Support for custom Livechat registration form fields May 8, 2020
@renatobecker renatobecker changed the title [NEW] [ENTERPRISE] Support for custom Livechat registration form fields [WIP][NEW] [ENTERPRISE] Support for custom Livechat registration form fields May 12, 2020
@renatobecker renatobecker changed the title [WIP][NEW] [ENTERPRISE] Support for custom Livechat registration form fields [NEW] [ENTERPRISE] Support for custom Livechat registration form fields May 12, 2020
Copy link
Member

@ggazzo ggazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good feature!!! I splitted the review in two parts that one is just the first step, I tested but not deeply yet, just suggested some important improvements, focusing mainly in code style and how to use better the features that the language offers

ee/app/livechat-enterprise/server/hooks/onLoadConfigApi.js Outdated Show resolved Hide resolved
ee/app/livechat-enterprise/server/lib/Helper.js Outdated Show resolved Hide resolved
app/livechat/client/views/app/tabbar/visitorEdit.js Outdated Show resolved Hide resolved
@renatobecker
Copy link
Contributor Author

renatobecker commented May 18, 2020

Good feature!!! I splitted the review in two parts that one is just the first step, I tested but not deeply yet, just suggested some important improvements, focusing mainly in code style and how to use better the features that the language offers

Thanks @ggazzo for reviewing.
I just submitted some changes that you suggested.

@rodrigok rodrigok changed the title [NEW] [ENTERPRISE] Support for custom Livechat registration form fields [NEW][ENTERPRISE] Support for custom Livechat registration form fields May 21, 2020
@sampaiodiego sampaiodiego merged commit 4aed76d into develop May 21, 2020
@sampaiodiego sampaiodiego deleted the omnichannel/support-custom-fields-livechat-registration-forms branch May 21, 2020 04:20
This was referenced May 28, 2020
gabriellsh added a commit that referenced this pull request May 29, 2020
…apps_rewrite

* 'develop' of github.com:RocketChat/Rocket.Chat: (30 commits)
  Regression: Fix Unread bar design (#17750)
  Regression: Adjusting spaces between OAuth login buttons (#17745)
  Improved thread margins for clarity
  Regression: Scroll on admin user info (#17711)
  Regression: Removed status border on mentions list (#17741)
  Regression: Force unread-rooms bar to appears over the room list (#17728)
  [NEW][APPS-ENGINE] Essentials mechanism (#17656)
  Regression: Fix error preventing creation of group DMs (#17726)
  [FIX] SAML IDP initiated logout error (#17482)
  Regression: Threads list was fetching all threads (#17716)
  Regression: Add missing return to afterSaveMessage callbacks (#17715)
  [FIX] Missing dropdown to select custom status color on user's profile (#16537)
  [FIX] Password reset/change accepting current password as new password (#16331)
  [NEW][ENTERPRISE] Support Omnichannel conversations auditing (#17692)
  Upgrade Livechat Widget version to 1.5.0 (#17710)
  [FIX] Can't click on room's actions menu of sidebar list when in search mode (#16548)
  [NEW][ENTERPRISE] Support for custom Livechat registration form fields (#17581)
  Update Fuselage version (#17708)
  [NEW][ENTERPRISE] Omnichannel Last-Chatted Agent Preferred option (#17666)
  Regression: Status presence  color (#17707)
  ...
@mmsbr
Copy link

mmsbr commented Jun 2, 2020

This Enterprise features means that it is only available on official paid server?

@renatobecker
Copy link
Contributor Author

This Enterprise features means that it is only available on official paid server?

It means, actually, that you need to get a license to run the Enterprise features.
If you take a look at our Pricing Page you'll notice that some of the features are only available on the Enterprise plan.

Thanks.

ggazzo added a commit that referenced this pull request Jun 3, 2020
…/new-threads* 'develop' of github.com:RocketChat/Rocket.Chat: (54 commits) Submit a payload to the release service when a release happens (#17775)  Regression: Fix Unread bar design (#17750)  Regression: Adjusting spaces between OAuth login buttons (#17745)  Improved thread margins for clarity  Regression: Scroll on admin user info (#17711)  Regression: Removed status border on mentions list (#17741)  Regression: Force unread-rooms bar to appears over the room list (#17728)  [NEW][APPS-ENGINE] Essentials mechanism (#17656)  Regression: Fix error preventing creation of group DMs (#17726)  [FIX] SAML IDP initiated logout error (#17482)  Regression: Threads list was fetching all threads (#17716)  Regression: Add missing return to afterSaveMessage callbacks (#17715)  [FIX] Missing dropdown to select custom status color on user's profile (#16537)  [FIX] Password reset/change accepting current password as new password (#16331)  [NEW][ENTERPRISE] Support Omnichannel conversations auditing (#17692)  Upgrade Livechat Widget version to 1.5.0 (#17710)  [FIX] Can't click on room's actions menu of sidebar list when in search mode (#16548)  [NEW][ENTERPRISE] Support for custom Livechat registration form fields (#17581)  Update Fuselage version (#17708)  [NEW][ENTERPRISE] Omnichannel Last-Chatted Agent Preferred option (#17666)  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants