Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEW][APPS-ENGINE] Essentials mechanism #17656

Merged
merged 15 commits into from
May 25, 2020
Merged

Conversation

d-gubert
Copy link
Member

@d-gubert d-gubert commented May 15, 2020

Implementation for RocketChat/Rocket.Chat.Apps-engine#269

Mainly improves the visualization of error messages originating from the essentials mechanism

@d-gubert d-gubert changed the base branch from develop to apps/new-room-events May 15, 2020 03:34
@d-gubert d-gubert requested a review from rodrigok May 15, 2020 03:35
@d-gubert d-gubert marked this pull request as draft May 15, 2020 03:38
@d-gubert d-gubert marked this pull request as ready for review May 15, 2020 21:34
rodrigok
rodrigok previously approved these changes May 16, 2020
@sampaiodiego
Copy link
Member

can you fix the conflicts please? there is also an error as stated here: https://github.com/RocketChat/Rocket.Chat/pull/17656/files#diff-59771c3aa115644893a53436db956059R1

@d-gubert d-gubert changed the base branch from apps/new-room-events to develop May 22, 2020 22:23
@d-gubert d-gubert dismissed rodrigok’s stale review May 22, 2020 22:23

The base branch was changed.

@rodrigok rodrigok added this to the 3.3.0 milestone May 25, 2020
@rodrigok rodrigok merged commit bab21b3 into develop May 25, 2020
@rodrigok rodrigok deleted the apps/essentials-mechanism branch May 25, 2020 17:47
This was referenced May 28, 2020
gabriellsh added a commit that referenced this pull request May 29, 2020
…apps_rewrite

* 'develop' of github.com:RocketChat/Rocket.Chat: (30 commits)
  Regression: Fix Unread bar design (#17750)
  Regression: Adjusting spaces between OAuth login buttons (#17745)
  Improved thread margins for clarity
  Regression: Scroll on admin user info (#17711)
  Regression: Removed status border on mentions list (#17741)
  Regression: Force unread-rooms bar to appears over the room list (#17728)
  [NEW][APPS-ENGINE] Essentials mechanism (#17656)
  Regression: Fix error preventing creation of group DMs (#17726)
  [FIX] SAML IDP initiated logout error (#17482)
  Regression: Threads list was fetching all threads (#17716)
  Regression: Add missing return to afterSaveMessage callbacks (#17715)
  [FIX] Missing dropdown to select custom status color on user's profile (#16537)
  [FIX] Password reset/change accepting current password as new password (#16331)
  [NEW][ENTERPRISE] Support Omnichannel conversations auditing (#17692)
  Upgrade Livechat Widget version to 1.5.0 (#17710)
  [FIX] Can't click on room's actions menu of sidebar list when in search mode (#16548)
  [NEW][ENTERPRISE] Support for custom Livechat registration form fields (#17581)
  Update Fuselage version (#17708)
  [NEW][ENTERPRISE] Omnichannel Last-Chatted Agent Preferred option (#17666)
  Regression: Status presence  color (#17707)
  ...
ggazzo added a commit that referenced this pull request Jun 3, 2020
…/new-threads* 'develop' of github.com:RocketChat/Rocket.Chat: (54 commits) Submit a payload to the release service when a release happens (#17775)  Regression: Fix Unread bar design (#17750)  Regression: Adjusting spaces between OAuth login buttons (#17745)  Improved thread margins for clarity  Regression: Scroll on admin user info (#17711)  Regression: Removed status border on mentions list (#17741)  Regression: Force unread-rooms bar to appears over the room list (#17728)  [NEW][APPS-ENGINE] Essentials mechanism (#17656)  Regression: Fix error preventing creation of group DMs (#17726)  [FIX] SAML IDP initiated logout error (#17482)  Regression: Threads list was fetching all threads (#17716)  Regression: Add missing return to afterSaveMessage callbacks (#17715)  [FIX] Missing dropdown to select custom status color on user's profile (#16537)  [FIX] Password reset/change accepting current password as new password (#16331)  [NEW][ENTERPRISE] Support Omnichannel conversations auditing (#17692)  Upgrade Livechat Widget version to 1.5.0 (#17710)  [FIX] Can't click on room's actions menu of sidebar list when in search mode (#16548)  [NEW][ENTERPRISE] Support for custom Livechat registration form fields (#17581)  Update Fuselage version (#17708)  [NEW][ENTERPRISE] Omnichannel Last-Chatted Agent Preferred option (#17666)  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants