Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression: Add missing return to afterSaveMessage callbacks #17715

Merged
merged 1 commit into from
May 21, 2020
Merged

Regression: Add missing return to afterSaveMessage callbacks #17715

merged 1 commit into from
May 21, 2020

Conversation

sampaiodiego
Copy link
Member

No description provided.

@sampaiodiego sampaiodiego added this to the 3.3.0 milestone May 21, 2020
@sampaiodiego sampaiodiego changed the title Regression: Add return to afterSaveMessage callbacks Regression: Add missing return to afterSaveMessage callbacks May 21, 2020
renatobecker
renatobecker approved these changes May 21, 2020
View reviewed changes
Copy link
Contributor

@renatobecker renatobecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works perfectly.

@sampaiodiego sampaiodiego merged commit 35ebde3 into develop May 21, 2020
@sampaiodiego sampaiodiego deleted the regression-add-return-to-callbacks branch May 21, 2020 18:39
This was referenced May 28, 2020
Merged
Merged
gabriellsh added a commit that referenced this pull request May 29, 2020
@gabriellsh
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into new/…
b152498 
…apps_rewrite

* 'develop' of github.com:RocketChat/Rocket.Chat: (30 commits)
  Regression: Fix Unread bar design (#17750)
  Regression: Adjusting spaces between OAuth login buttons (#17745)
  Improved thread margins for clarity
  Regression: Scroll on admin user info (#17711)
  Regression: Removed status border on mentions list (#17741)
  Regression: Force unread-rooms bar to appears over the room list (#17728)
  [NEW][APPS-ENGINE] Essentials mechanism (#17656)
  Regression: Fix error preventing creation of group DMs (#17726)
  [FIX] SAML IDP initiated logout error (#17482)
  Regression: Threads list was fetching all threads (#17716)
  Regression: Add missing return to afterSaveMessage callbacks (#17715)
  [FIX] Missing dropdown to select custom status color on user's profile (#16537)
  [FIX] Password reset/change accepting current password as new password (#16331)
  [NEW][ENTERPRISE] Support Omnichannel conversations auditing (#17692)
  Upgrade Livechat Widget version to 1.5.0 (#17710)
  [FIX] Can't click on room's actions menu of sidebar list when in search mode (#16548)
  [NEW][ENTERPRISE] Support for custom Livechat registration form fields (#17581)
  Update Fuselage version (#17708)
  [NEW][ENTERPRISE] Omnichannel Last-Chatted Agent Preferred option (#17666)
  Regression: Status presence  color (#17707)
  ...
ggazzo added a commit that referenced this pull request Jun 3, 2020
@ggazzo
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into feat…
e38a519 
…/new-threads* 'develop' of github.com:RocketChat/Rocket.Chat: (54 commits) Submit a payload to the release service when a release happens (#17775)  Regression: Fix Unread bar design (#17750)  Regression: Adjusting spaces between OAuth login buttons (#17745)  Improved thread margins for clarity  Regression: Scroll on admin user info (#17711)  Regression: Removed status border on mentions list (#17741)  Regression: Force unread-rooms bar to appears over the room list (#17728)  [NEW][APPS-ENGINE] Essentials mechanism (#17656)  Regression: Fix error preventing creation of group DMs (#17726)  [FIX] SAML IDP initiated logout error (#17482)  Regression: Threads list was fetching all threads (#17716)  Regression: Add missing return to afterSaveMessage callbacks (#17715)  [FIX] Missing dropdown to select custom status color on user's profile (#16537)  [FIX] Password reset/change accepting current password as new password (#16331)  [NEW][ENTERPRISE] Support Omnichannel conversations auditing (#17692)  Upgrade Livechat Widget version to 1.5.0 (#17710)  [FIX] Can't click on room's actions menu of sidebar list when in search mode (#16548)  [NEW][ENTERPRISE] Support for custom Livechat registration form fields (#17581)  Update Fuselage version (#17708)  [NEW][ENTERPRISE] Omnichannel Last-Chatted Agent Preferred option (#17666)  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renatobecker renatobecker renatobecker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@sampaiodiego @renatobecker