Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEW] Create header for new homepage #25795

Merged
merged 6 commits into from
Jun 9, 2022
Merged

Conversation

guijun13
Copy link
Contributor

@guijun13 guijun13 commented Jun 7, 2022

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

TODO:

  • isAdmin permission

@guijun13 guijun13 changed the title [NEW]: Create header for new homepage [NEW] Create header for new homepage Jun 7, 2022
@guijun13 guijun13 marked this pull request as ready for review June 9, 2022 15:20
@guijun13 guijun13 requested a review from a team as a code owner June 9, 2022 15:20
Copy link
Member

@dougfabris dougfabris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@guijun13 Having this new page, I think we can remove the old burger menu 😃

@guijun13
Copy link
Contributor Author

guijun13 commented Jun 9, 2022

@guijun13 Having this new page, I think we can remove the old burger menu smiley

Removed! Thanks, @dougfabris

… feat/new-header

* 'new/homepage' of github.com:RocketChat/Rocket.Chat:
  [NEW] Add Custom homepage Content Setting (#25777)
  Chore: Fix CI (#25797)
  [FIX] Fix prom-client new promise usage (#25781)
  [FIX] Discussion alphabetical  ordering (#25788)
  Update .kodiak.toml
  Update .kodiak.toml
  Chore: Testing Kodiak feature (#25794)
  [FIX] Broken Omnichannel>Agents page (#25731)
  [FIX] Sanitize styles in message (#25744)
  chore: Convert to TS RoomAutoComplete (#25536)
  Chore: API test on method GET with params as a number. (#25769)
  Chore: convert invites, misc and subscriptions to TS and create definitions (#25350)
  Chore: Remove .snapcraft
  Chore: Remove toastr package (#25787)
  [BREAK] Remove Blockstack authentication (#25649)
  [FIX] getUserMentionsByChannel method room permission (#25748)
  [NEW] Fuselage ToastBar (#25583)
@gabriellsh gabriellsh merged commit 9bf7f90 into new/homepage Jun 9, 2022
@gabriellsh gabriellsh deleted the feat/new-header branch June 9, 2022 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants