Regression: Fix Current Chats Page Issues #26744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #26744 +/- ##
===========================================
+ Coverage 40.63% 40.64% +0.01%
===========================================
Files 799 799
Lines 18309 18309
Branches 1957 1957
===========================================
+ Hits 7439 7442 +3
- Misses 10574 10575 +1
+ Partials 296 292 -4
Flags with carried forward coverage won't be shown. Click here to find out more. |
dougfabris
requested changes
Aug 30, 2022
apps/meteor/client/views/omnichannel/currentChats/CurrentChatsRoute.tsx
Outdated
Show resolved
Hide resolved
apps/meteor/client/views/omnichannel/currentChats/CurrentChatsRoute.tsx
Outdated
Show resolved
Hide resolved
dougfabris
approved these changes
Aug 30, 2022
ggazzo
previously requested changes
Aug 30, 2022
MartinSchoeler
dismissed
ggazzo’s stale review
We've yet to finish the framework to be able to tests the whole currentchats page, this is something that will be done soon, so if we could skip the tests for this PR it would be good
gabriellsh
added a commit
that referenced
this pull request
Sep 1, 2022
* origin/develop: Chore: Fix docker latest tag push (#26770) Regression: Custom fields not being saved for room (#26747) Regression: Fix Current Chats Page Issues (#26744) Regression: Empty custom-fields filter on Current Chats causing issues (#26720) Regression: Sidebar Search list local data cache and keyboard navigation (#26764) Regression: Select settings options not visible on Apps Setting panel (#26759) Regression: AutoTranslate is disabled error (#26701) Regression: REST setUserPublicAndPrivateKeys (#26753) Regression: Workaround to handle auto stopped computations 😞 (#26745)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes:
Steps to reproduce
Reset button:
...menuSorting