Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: Sidebar Search list local data cache and keyboard navigation #26764

Merged
merged 1 commit into from
Aug 31, 2022

Conversation

gabriellsh
Copy link
Member

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@gabriellsh gabriellsh requested a review from a team as a code owner August 31, 2022 13:43
@codecov
Copy link

codecov bot commented Aug 31, 2022

Codecov Report

Merging #26764 (d560210) into develop (1b63693) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #26764      +/-   ##
===========================================
- Coverage    40.63%   40.61%   -0.02%     
===========================================
  Files          799      799              
  Lines        18309    18309              
  Branches      1957     1957              
===========================================
- Hits          7439     7436       -3     
- Misses       10574    10575       +1     
- Partials       296      298       +2     
Flag Coverage Δ
e2e 40.61% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Aug 31, 2022
@ggazzo ggazzo merged commit 1599a22 into develop Aug 31, 2022
@ggazzo ggazzo deleted the fix/searchList branch August 31, 2022 14:50
@alvaropmello alvaropmello added this to the 5.1.0 milestone Aug 31, 2022
gabriellsh added a commit that referenced this pull request Sep 1, 2022
* origin/develop:
  Chore: Fix docker latest tag push (#26770)
  Regression: Custom fields not being saved for room (#26747)
  Regression: Fix Current Chats Page Issues (#26744)
  Regression: Empty custom-fields filter on Current Chats causing issues (#26720)
  Regression: Sidebar Search list local data cache and keyboard navigation (#26764)
  Regression: Select settings options not visible on Apps Setting panel (#26759)
  Regression: AutoTranslate is disabled error (#26701)
  Regression: REST setUserPublicAndPrivateKeys (#26753)
  Regression: Workaround to handle auto stopped computations 😞 (#26745)
@murtaza98 murtaza98 mentioned this pull request Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA tested stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants