Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: Empty custom-fields filter on Current Chats causing issues #26720

Merged
merged 7 commits into from
Aug 31, 2022

Conversation

murtaza98
Copy link
Contributor

@murtaza98 murtaza98 commented Aug 29, 2022

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Clickup: https://app.clickup.com/t/2r65yjw

@murtaza98 murtaza98 added this to the 5.1.0 milestone Aug 29, 2022
@murtaza98 murtaza98 requested a review from a team as a code owner August 29, 2022 07:21
@codecov
Copy link

codecov bot commented Aug 29, 2022

Codecov Report

Merging #26720 (ef2c3c6) into develop (a0ce67f) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #26720      +/-   ##
===========================================
- Coverage    40.64%   40.61%   -0.03%     
===========================================
  Files          799      799              
  Lines        18309    18309              
  Branches      1957     1957              
===========================================
- Hits          7441     7437       -4     
- Misses       10574    10576       +2     
- Partials       294      296       +2     
Flag Coverage Δ
e2e 40.61% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Aug 30, 2022
@ggazzo ggazzo merged commit d860c34 into develop Aug 31, 2022
@ggazzo ggazzo deleted the reg/omni-empty-cf branch August 31, 2022 16:39
gabriellsh added a commit that referenced this pull request Sep 1, 2022
* origin/develop:
  Chore: Fix docker latest tag push (#26770)
  Regression: Custom fields not being saved for room (#26747)
  Regression: Fix Current Chats Page Issues (#26744)
  Regression: Empty custom-fields filter on Current Chats causing issues (#26720)
  Regression: Sidebar Search list local data cache and keyboard navigation (#26764)
  Regression: Select settings options not visible on Apps Setting panel (#26759)
  Regression: AutoTranslate is disabled error (#26701)
  Regression: REST setUserPublicAndPrivateKeys (#26753)
  Regression: Workaround to handle auto stopped computations 😞 (#26745)
@murtaza98 murtaza98 mentioned this pull request Sep 2, 2022
ggazzo pushed a commit that referenced this pull request Sep 5, 2022
@tassoevan tassoevan mentioned this pull request Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA tested stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants