chore: Deprecate mute/unmute meteor methods and convert to endpoint #31811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f094d42 The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #31811 +/- ##
===========================================
- Coverage 55.36% 55.35% -0.02%
===========================================
Files 2330 2327 -3
Lines 51392 51395 +3
Branches 10516 10498 -18
===========================================
- Hits 28453 28449 -4
- Misses 20416 20427 +11
+ Partials 2523 2519 -4
Flags with carried forward coverage won't be shown. Click here to find out more. |
csuadev
previously approved these changes
Feb 22, 2024
Gustrb
reviewed
Feb 22, 2024
Gustrb
reviewed
Feb 22, 2024
Gustrb
reviewed
Feb 22, 2024
Gustrb
reviewed
Feb 22, 2024
matheusbsilva137
requested changes
Feb 22, 2024
matheusbsilva137
previously approved these changes
Feb 22, 2024
MarcosSpessatto
previously approved these changes
Feb 22, 2024
yash-rajpal
changed the title
yash-rajpal
changed the title
|
since 7.0 was delayed, should we target 7.0 to remove the Meteor methods? 😬 |
|
Looks like this PR is ready to merge! 🎉 |
Wouldn't it still be too close to deprecate them on 6.8 and remove them on the next version? |
yes, a little bit.. BUT these are Meteor methods (or the realtime API) which is something we want to get rid of asap |
ggazzo
dismissed stale reviews from MarcosSpessatto and matheusbsilva137
via
a711932
ggazzo
previously approved these changes
Apr 23, 2024
ggazzo
force-pushed
the
chore/mute-unmute-endpoints
branch
from
a711932
to
f094d42
Compare
ggazzo
approved these changes
Apr 23, 2024
sampaiodiego
approved these changes
Apr 23, 2024
sampaiodiego
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
Merged
gabriellsh
added a commit
that referenced
this pull request
Apr 23, 2024
…engagementMDM * 'develop' of github.com:RocketChat/Rocket.Chat: chore: including x.com hostname to Twitter oembed (#32267) feat: node-gcm deprecation (#32208) chore: Deprecate mute/unmute meteor methods and convert to endpoint (#31811) fix: Wrong Business hours validations between different weeks (#32287) chore: Force logout live clients on E2EE keys reset changes (#32291) ci: skip update version message for TEST_MODE=true (#32293)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments
CORE-92