Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: skip update version message for TEST_MODE=true #32293

Merged
merged 1 commit into from
Apr 22, 2024
Merged

ci: skip update version message for TEST_MODE=true #32293

merged 1 commit into from
Apr 22, 2024

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Apr 22, 2024

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 22, 2024

⚠️ No Changeset found

Latest commit: 4d83cfc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov Codecov
Copy link

codecov bot commented Apr 22, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.38%. Comparing base (ab737d0) to head (4d83cfc).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #32293   +/-   ##
========================================
  Coverage    55.38%   55.38%           
========================================
  Files         2327     2327           
  Lines        51357    51357           
  Branches     10509    10509           
========================================
  Hits         28446    28446           
- Misses       20397    20426   +29     
+ Partials      2514     2485   -29
Flag Coverage Δ
unit 74.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo marked this pull request as ready for review April 22, 2024 20:48
@ggazzo ggazzo added this to the 6.8 milestone Apr 22, 2024
@dionisio-bot dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Apr 22, 2024 •
edited
Loading

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Apr 22, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Apr 22, 2024
@ggazzo ggazzo merged commit 67e3480 into develop Apr 22, 2024
33 of 37 checks passed
@ggazzo ggazzo deleted the ci/skip-version-check-ci-test-mode branch April 22, 2024 20:58
@ggazzo
Copy link
Member Author

ggazzo commented Apr 22, 2024

/backport 6.6.7

dionisio-bot bot pushed a commit that referenced this pull request Apr 22, 2024
@ggazzo
ci: skip update version message for TEST_MODE=true (#32293)
e76f769
@dionisio-bot dionisio-bot bot mentioned this pull request Apr 22, 2024
Merged
@dionisio-bot dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Apr 22, 2024

Pull request #32294 added to Project: "Patch 6.6.7"

gabriellsh added a commit that referenced this pull request Apr 23, 2024
@gabriellsh
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into fix/…
d615eb6 
…engagementMDM

* 'develop' of github.com:RocketChat/Rocket.Chat:
  chore: including x.com hostname to Twitter oembed (#32267)
  feat: node-gcm deprecation (#32208)
  chore: Deprecate mute/unmute meteor methods and convert to endpoint (#31811)
  fix:  Wrong Business hours validations between different weeks (#32287)
  chore: Force logout live clients on E2EE keys reset changes (#32291)
  ci: skip update version message for TEST_MODE=true (#32293)
@ggazzo
Copy link
Member Author

ggazzo commented May 17, 2024

/backport 6.7.3

1 similar comment
@sampaiodiego
Copy link
Member

/backport 6.7.3

dionisio-bot bot pushed a commit that referenced this pull request May 17, 2024
@ggazzo
ci: skip update version message for TEST_MODE=true (#32293)
cc9a2a0
@dionisio-bot dionisio-bot bot mentioned this pull request May 17, 2024
Merged
@dionisio-bot dionisio-bot
Copy link
Contributor

dionisio-bot bot commented May 17, 2024

Pull request #32455 added to Project: "Patch 6.7.3"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sampaiodiego sampaiodiego sampaiodiego approved these changes

Assignees
No one assigned
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Milestone
6.8
Development

Successfully merging this pull request may close these issues.
2 participants
@ggazzo @sampaiodiego