Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Force logout live clients on E2EE keys reset changes #32291

Merged
merged 8 commits into from
Apr 23, 2024
Merged

chore: Force logout live clients on E2EE keys reset changes #32291

merged 8 commits into from
Apr 23, 2024

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Apr 22, 2024 •
edited
Loading

Proposed changes (including videos or screenshots)

Only counting on client to logout is a weak strategy, so now we are closing the connections properly on microservices

Issue(s)

Introduced here: #31958
E2EE-10

Steps to test or reproduce

Further comments

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 22, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 889767e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov Codecov
Copy link

codecov bot commented Apr 22, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.42%. Comparing base (67e3480) to head (889767e).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32291      +/-   ##
===========================================
+ Coverage    55.36%   55.42%   +0.05%     
===========================================
  Files         2330     2329       -1     
  Lines        51392    51361      -31     
  Branches     10516    10510       -6     
===========================================
+ Hits         28453    28466      +13     
+ Misses       20416    20378      -38     
+ Partials      2523     2517       -6
Flag Coverage Δ
e2e 54.85% <ø> (+0.10%) ⬆️
unit 74.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo marked this pull request as ready for review April 22, 2024 20:48
@ggazzo ggazzo requested a review from a team as a code owner April 22, 2024 20:48
@ggazzo ggazzo added this to the 6.8 milestone Apr 22, 2024
@dionisio-bot dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Apr 22, 2024 •
edited
Loading

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

MartinSchoeler
MartinSchoeler previously approved these changes Apr 22, 2024
View reviewed changes
Copy link
Contributor

@MartinSchoeler MartinSchoeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@MartinSchoeler MartinSchoeler added the stat: QA assured Means it has been tested and approved by a company insider label Apr 22, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Apr 22, 2024
@ggazzo ggazzo requested a review from a team as a code owner April 22, 2024 21:22
rodrigok
rodrigok previously approved these changes Apr 22, 2024
View reviewed changes
@ggazzo ggazzo changed the title test: fix e2e encryption tests chore: Force logout live clients on E2EE keys reset changes Apr 23, 2024
@ggazzo ggazzo merged commit f423d7f into develop Apr 23, 2024
46 checks passed
@ggazzo ggazzo deleted the test/e2e-encription branch April 23, 2024 04:20
gabriellsh added a commit that referenced this pull request Apr 23, 2024
@gabriellsh
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into fix/…
d615eb6 
…engagementMDM

* 'develop' of github.com:RocketChat/Rocket.Chat:
  chore: including x.com hostname to Twitter oembed (#32267)
  feat: node-gcm deprecation (#32208)
  chore: Deprecate mute/unmute meteor methods and convert to endpoint (#31811)
  fix:  Wrong Business hours validations between different weeks (#32287)
  chore: Force logout live clients on E2EE keys reset changes (#32291)
  ci: skip update version message for TEST_MODE=true (#32293)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierre-lehnen-rc pierre-lehnen-rc pierre-lehnen-rc approved these changes

@rodrigok rodrigok rodrigok left review comments

@MartinSchoeler MartinSchoeler MartinSchoeler left review comments

Assignees
No one assigned
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Milestone
6.8
Development

Successfully merging this pull request may close these issues.
4 participants
@ggazzo @rodrigok @MartinSchoeler @pierre-lehnen-rc