Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "fix: Inconsistent Markdown Formatting in Custom Status Field" #33127

Merged
merged 4 commits into from
Aug 22, 2024
Merged

Revert "fix: Inconsistent Markdown Formatting in Custom Status Field" #33127

merged 4 commits into from
Aug 22, 2024

Conversation

csuadev
Copy link
Contributor

@csuadev csuadev commented Aug 22, 2024 •
edited by jira bot
Loading

Reverts #32574 from community since there are some scenarios where it is making channels to break where the MarkdownComponent is used.

Task: SUP-537 CORE-651

@dionisio-bot dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Aug 22, 2024 •
edited
Loading

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 22, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 955156e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@csuadev csuadev marked this pull request as ready for review August 22, 2024 16:56
@csuadev csuadev requested a review from a team as a code owner August 22, 2024 16:56
@codecov Codecov
Copy link

codecov bot commented Aug 22, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.38%. Comparing base (c079498) to head (955156e).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #33127   +/-   ##
========================================
  Coverage    59.38%   59.38%           
========================================
  Files         2547     2547           
  Lines        63238    63238           
  Branches     14224    14224           
========================================
  Hits         37557    37557           
  Misses       22974    22974           
  Partials      2707     2707
Flag Coverage Δ
unit 75.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@scuciatto scuciatto added this to the 6.12 milestone Aug 22, 2024
@KevLehman
Copy link
Contributor

Can you describe the scenarios or link a task related with this revert? Also, the original PR was closign a support issue + 2 github issues, should we re-open them?

@jessicaschelly jessicaschelly added the stat: QA assured Means it has been tested and approved by a company insider label Aug 22, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Aug 22, 2024
KevLehman
KevLehman requested changes Aug 22, 2024
View reviewed changes
Copy link
Contributor

@KevLehman KevLehman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the above comment

@scuciatto
Copy link
Member

Can you describe the scenarios or link a task related with this revert? Also, the original PR was closign a support issue + 2 github issues, should we re-open them?

I reopened the tasks and GH issues

@KevLehman
Copy link
Contributor

Thanks @scuciatto !

@KevLehman KevLehman added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Aug 22, 2024
@kodiakhq kodiakhq bot merged commit b213181 into develop Aug 22, 2024
49 checks passed
@kodiakhq kodiakhq bot deleted the revert-32574-fix/apply-strong-if-asterisk branch August 22, 2024 22:37
gabriellsh added a commit that referenced this pull request Sep 2, 2024
@gabriellsh
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into impr…
e9b49ff 
…ove/threadMetrics

* 'develop' of github.com:RocketChat/Rocket.Chat: (49 commits)
  feat: add `sidepanelNavigation` to Feature preview list (#33156)
  refactor: Realtime Monitoring Counters to TS (#33182)
  fix: restore tooltips to units Multiselect (#33174)
  test: Add unit test for RoomMenu options (#32891)
  chore: remove notifyListener call that was causing startup issues (#33154)
  fix: Multi-step modals closing unexpectedly (#33158)
  Revert "refactor: Realtime Monitoring Counters to TS" (#33170)
  refactor: Realtime Monitoring Counters to TS (#33166)
  refactor: Uses `source` instead of `room` to render the `OmnichannelRoomIcon` (#33118)
  refactor: Realtime Monitoring Overviews to TS (#33167)
  test: Add e2e tests for teams multi-step modals (#33168)
  feat: add Advanced settings accordion to `EditRoomInfo` (#33114)
  chore: Revive Livechat Storybook (#33137)
  refactor: Realtime `Doughnout Charts` to TS (#33092)
  feat: create contact endpoint (#32693)
  chore: remove left streaming code (#33039)
  fix: show only relevant userInfoActions for mentioned non-members (#31525)
  feat: Setting for enabling files encryption and fix whitelist media types stopping E2EE uploads (#33003)
  refactor: Replace proxy functions from `LivechatTyped` class with direct calls (#33110)
  Revert "fix: Inconsistent Markdown Formatting in Custom Status Field" (#33127)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KevLehman KevLehman KevLehman approved these changes

@yash-rajpal yash-rajpal yash-rajpal approved these changes

Assignees
No one assigned
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Milestone
6.12
Development

Successfully merging this pull request may close these issues.
5 participants
@csuadev @KevLehman @scuciatto @yash-rajpal @jessicaschelly