Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Omnichannel): Use Correct components on ChatInfo #32592

Merged
merged 6 commits into from
Jul 11, 2024
Merged

Conversation

MartinSchoeler
Copy link
Contributor

@MartinSchoeler MartinSchoeler commented Jun 12, 2024

CORE-477

Fixes Missing line breaks on Omnichannel Room Info Panel by using the correct component for data view

Copy link
Contributor

dionisio-bot bot commented Jun 12, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Jun 12, 2024

🦋 Changeset detected

Latest commit: 3dc0548

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Jun 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.78%. Comparing base (f2cb691) to head (3dc0548).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32592      +/-   ##
===========================================
+ Coverage    56.65%   56.78%   +0.13%     
===========================================
  Files         2504     2504              
  Lines        55524    55514      -10     
  Branches     11442    11439       -3     
===========================================
+ Hits         31456    31526      +70     
+ Misses       21380    21277     -103     
- Partials      2688     2711      +23     
Flag Coverage Δ
e2e 56.47% <ø> (+0.02%) ⬆️
unit 72.23% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@MartinSchoeler MartinSchoeler marked this pull request as ready for review June 12, 2024 16:22
@MartinSchoeler MartinSchoeler requested a review from a team as a code owner June 12, 2024 16:22
csuadev
csuadev previously approved these changes Jun 12, 2024
@scuciatto scuciatto removed this from the 6.10 milestone Jun 20, 2024
@ggazzo ggazzo added this to the 6.11 milestone Jun 26, 2024
@jessicaschelly jessicaschelly added the stat: QA assured Means it has been tested and approved by a company insider label Jul 8, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jul 8, 2024
Copy link
Member

@dougfabris dougfabris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please avoid using InfoPanel.Component notation. Instead prefer using InfoPanelComponent

Copy link
Member

@dougfabris dougfabris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dionisio-bot dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label Jul 11, 2024
@MartinSchoeler MartinSchoeler added the stat: ready to merge PR tested and approved waiting for merge label Jul 11, 2024
@kodiakhq kodiakhq bot merged commit d7de0a9 into develop Jul 11, 2024
51 checks passed
@kodiakhq kodiakhq bot deleted the CORE-477 branch July 11, 2024 16:58
gabriellsh added a commit that referenced this pull request Jul 12, 2024
…/removeUsers

* 'develop' of github.com:RocketChat/Rocket.Chat:
  refactor(omnichannel): replace create and find by findAndUpdate (#32773)
  chore: Bump apps engine 1.44-alpha (#32774)
  refactor(client): Remove usage of `React.FC` type (#32760)
  refactor(Livechat): `Livechat/Message/markdown.js` -> TS (#32295)
  refactor(omnichannel): spare few Room.find on requestRoom method (#32363)
  refactor:  `dispatchInquiryPosition` being called multiple times (#32767)
  fix: SAML "Overwrite user fullname" setting is not being honored (#32628)
  fix(Omnichannel): Use Correct components on ChatInfo (#32592)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants