fix: SAML "Overwrite user fullname" setting is not being honored #32628
+55
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 7652eb5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #32628 +/- ##
===========================================
+ Coverage 56.68% 56.84% +0.16%
===========================================
Files 2504 2501 -3
Lines 55524 55383 -141
Branches 11442 11422 -20
===========================================
+ Hits 31472 31485 +13
+ Misses 21368 21184 -184
- Partials 2684 2714 +30
Flags with carried forward coverage won't be shown. Click here to find out more. |
MarcosSpessatto
requested changes
Jun 19, 2024
…at/Rocket.Chat into fix/saml-name-overwrite
…nto fix/saml-name-overwrite
MarcosSpessatto
previously approved these changes
Jun 19, 2024
…nto fix/saml-name-overwrite
jessicaschelly
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
MarcosSpessatto
approved these changes
Jul 11, 2024
dionisio-bot
bot
removed
the
stat: ready to merge
matheusbsilva137
added
the
stat: ready to merge
gabriellsh
added a commit
that referenced
this pull request
Jul 12, 2024
…/removeUsers * 'develop' of github.com:RocketChat/Rocket.Chat: refactor(omnichannel): replace create and find by findAndUpdate (#32773) chore: Bump apps engine 1.44-alpha (#32774) refactor(client): Remove usage of `React.FC` type (#32760) refactor(Livechat): `Livechat/Message/markdown.js` -> TS (#32295) refactor(omnichannel): spare few Room.find on requestRoom method (#32363) refactor: `dispatchInquiryPosition` being called multiple times (#32767) fix: SAML "Overwrite user fullname" setting is not being honored (#32628) fix(Omnichannel): Use Correct components on ChatInfo (#32592)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Expected behavior: the user's full name should only be updated/overwritten in case the "Overwrite user fullname (use idp attribute)" setting is enabled. Otherwise, it shouldn't be changed (even if the username is updated on login).
Current behavior the user's full name is updated regardless of the "Overwrite user fullname (use idp attribute)" setting.
Further comments
SUP-605