Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Bump apps engine 1.44-alpha #32774

Merged
merged 2 commits into from
Jul 12, 2024
Merged

chore: Bump apps engine 1.44-alpha #32774

merged 2 commits into from
Jul 12, 2024

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Jul 12, 2024

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@dionisio-bot dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Jul 12, 2024 •
edited
Loading

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jul 12, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: cc5018b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ggazzo ggazzo changed the title chore: Bump: apps engine 1.44-alpha chore: Bump apps engine 1.44-alpha Jul 12, 2024
ricardogarim
ricardogarim previously approved these changes Jul 12, 2024
View reviewed changes
@ggazzo ggazzo marked this pull request as ready for review July 12, 2024 12:49
@codecov Codecov
Copy link

codecov bot commented Jul 12, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.67%. Comparing base (99524f2) to head (cc5018b).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32774      +/-   ##
===========================================
- Coverage    56.67%   56.67%   -0.01%     
===========================================
  Files         2504     2504              
  Lines        55518    55518              
  Branches     11440    11440              
===========================================
- Hits         31464    31463       -1     
  Misses       21370    21370              
- Partials      2684     2685       +1
Flag Coverage Δ
e2e 56.50% <ø> (+<0.01%) ⬆️
unit 72.22% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo added this to the 6.11 milestone Jul 12, 2024
@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Jul 12, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jul 12, 2024
@ggazzo ggazzo requested a review from a team as a code owner July 12, 2024 13:22
@ggazzo ggazzo merged commit 753b08e into develop Jul 12, 2024
49 checks passed
@ggazzo ggazzo deleted the chore/bump-apps-engine branch July 12, 2024 15:09
gabriellsh added a commit that referenced this pull request Jul 12, 2024
@gabriellsh
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into apps…
08e175a 
…/removeUsers

* 'develop' of github.com:RocketChat/Rocket.Chat:
  refactor(omnichannel): replace create and find by findAndUpdate (#32773)
  chore: Bump apps engine 1.44-alpha (#32774)
  refactor(client): Remove usage of `React.FC` type (#32760)
  refactor(Livechat): `Livechat/Message/markdown.js` -> TS (#32295)
  refactor(omnichannel): spare few Room.find on requestRoom method (#32363)
  refactor:  `dispatchInquiryPosition` being called multiple times (#32767)
  fix: SAML "Overwrite user fullname" setting is not being honored (#32628)
  fix(Omnichannel): Use Correct components on ChatInfo (#32592)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ricardogarim ricardogarim ricardogarim left review comments

Assignees
No one assigned
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Milestone
6.11
Development

Successfully merging this pull request may close these issues.
2 participants
@ggazzo @ricardogarim