-
Notifications
You must be signed in to change notification settings - Fork 10.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Pressing esc whilst editing a message closes the contextual bar #32861
Conversation
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: f6de7b9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #32861 +/- ##
===========================================
- Coverage 55.59% 55.55% -0.05%
===========================================
Files 2637 2637
Lines 57308 57313 +5
Branches 11868 11869 +1
===========================================
- Hits 31860 31839 -21
- Misses 22754 22767 +13
- Partials 2694 2707 +13
Flags with carried forward coverage won't be shown. Click here to find out more. |
…32861) Co-authored-by: Douglas Fabris <[email protected]>
Proposed changes (including videos or screenshots)
There's 2 ways to attach an event listener to a component, using react props (onClick, onKeyDown, etc) or directly to the node (using a callbackRef or getting the element directly from the dom). Attaching events using both ways changes how event propagation works due to react's synthetic event handlers.
The issue was resolved by adding the composer keydown event using a callbackRef instead of as a prop.
Issue(s)
Steps to test or reproduce
Further comments
CORE-529