refactor: Reactions set/unset #32994

KevLehman · 2024-08-06T18:35:38Z

Proposed changes (including videos or screenshots)

Refactors chat.react endpoint to remove check for message (executeSetReaction already does it)
Refactors executeSetReaction to perform emoji & reactions check before all DB calls
Refactors executeSetReaction to use new countByNameOrAlias query instead of a find().count()
Refactors executeSetReaction to only request the required data when requesting room from DB
Refactor setReaction to not await for callbacks (we don't need the return value anyways)
Refactor setReaction to notify of room changed at the end of the function (instead of next to every update). This doesn't gain any perf, but looks better (and also fixes a missing notify).
Added unit tests for all functions (except the meteor.methods call...)

Issue(s)

https://rocketchat.atlassian.net/browse/CORE-597

Steps to test or reproduce

Further comments

dionisio-bot · 2024-08-06T18:35:42Z

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

changeset-bot · 2024-08-06T18:35:43Z

⚠️ No Changeset found

Latest commit: 1accdaf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

codecov · 2024-08-06T18:52:41Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.93%. Comparing base (6a3c25c) to head (9a2fc13).
Report is 5 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #32994      +/-   ##
===========================================
+ Coverage    59.85%   59.93%   +0.08%     
===========================================
  Files         2554     2556       +2     
  Lines        63008    63400     +392     
  Branches     14129    14246     +117     
===========================================
+ Hits         37711    37998     +287     
- Misses       22890    22969      +79     
- Partials      2407     2433      +26

Flag	Coverage Δ
unit	`77.20% <100.00%> (+0.05%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

apps/meteor/app/lib/server/functions/isTheLastMessage.ts

apps/meteor/app/reactions/server/setReaction.ts

apps/meteor/app/api/server/v1/chat.ts

apps/meteor/tests/unit/app/reactions/server/setReaction.spec.ts

github-actions · 2024-09-17T17:02:25Z

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-09-19 23:58 UTC

…on.ts

apps/meteor/app/reactions/server/setReaction.ts

everything done

…hAvatarById * 'develop' of github.com:RocketChat/Rocket.Chat: feat: Implement proper accessbility for report user modal (#33294) chore: update E2EE setting text (#33226) fix: conference calls are shown as "not answered" after they end (#33179) fix: markdown inconsistency with bold and italics (#33157) feat: E2EE messages mentions (#32510) refactor: Reactions set/unset (#32994) ci: auto candidate releases (#33325) feat: `RoomSidepanel` (#33225) feat: contextualbar based on chat size (#33321) fix: error on sendmessage stub (#33317) fix: `LivechatSessionTaken` webhook event called without `agent` param (#33209) refactor: Remove old `setreaction` callbacks and use new after/before callbacks (#33309) fix: Mark as unread not working (#32939) fix: Local avatars prioritized over external avatar provider and remove remnant references on client of `Accounts_AvatarExternalProviderUrl` (#33296) feat: Allow managing association to business units on departments' creation and update (#32682)

* Bump 6.12.1 * fix: message parser being slow to process very long messages with too many symbols (#33254) Co-authored-by: Pierre Lehnen <[email protected]> * fix: Allow to use the token from `room.v` when requesting transcript instead of finding visitor (#33242) Co-authored-by: Kevin Aleman <[email protected]> * fix: Retention Policy cached settings not updated during upgrade procedure (#33265) Co-authored-by: gabriellsh <[email protected]> * fix: imported fixes (#33268) Co-authored-by: Julio A. <[email protected]> * Release 6.12.1 [no ci] * fix: Federation callback not awaiting model call (#33298) * fix: correct parameter order in afterSaveMessage to restore outgoing webhooks and related features (#33295) * feat: New endpoint for listing rooms & discussions from teams (#33177) * chore: Update typings on callbacks to accept less than a full room object (#33305) * fix: resolve avatar download issue on setUsername by refining service selection logic (#33193) * feat: Allow managing association to business units on departments' creation and update (#32682) * fix: Local avatars prioritized over external avatar provider and remove remnant references on client of `Accounts_AvatarExternalProviderUrl` (#33296) Co-authored-by: gabriellsh <[email protected]> * fix: Mark as unread not working (#32939) Co-authored-by: Douglas Fabris <[email protected]> * refactor: Remove old `setreaction` callbacks and use new after/before callbacks (#33309) * fix: `LivechatSessionTaken` webhook event called without `agent` param (#33209) * fix: error on sendmessage stub (#33317) * feat: contextualbar based on chat size (#33321) * feat: `RoomSidepanel` (#33225) Co-authored-by: Guilherme Gazzo <[email protected]> * ci: auto candidate releases (#33325) Co-authored-by: Diego Sampaio <[email protected]> * refactor: Reactions set/unset (#32994) * feat: E2EE messages mentions (#32510) * fix: markdown inconsistency with bold and italics (#33157) * fix: conference calls are shown as "not answered" after they end (#33179) * Release 6.13.0-rc.0 * chore: update E2EE setting text (#33226) * feat: Implement proper accessbility for report user modal (#33294) Co-authored-by: Tasso Evangelista <[email protected]> * fix: imported fixes (#33330) * chore: create network broker package (#33338) * feat: Adds new admin feature preview setting management (#33212) Co-authored-by: Guilherme Gazzo <[email protected]> * chore: move common files to core-services (#33341) * regression: `Sidepanel` color highlight (#33342) * feat: Adds new admin feature preview setting management (#33212) Co-authored-by: Guilherme Gazzo <[email protected]> * fix: Avoid destructuring `connectionData` when value is undefined (#33339) * Release 6.13.0-rc.1 [no ci] * chore: replace Meteor._localStorage -> Accounts.storageLocation (#33356) * Bump rocket.chat to 6.14.0-develop (#33366) * ci: use node20 for release action (#33343) --------- Co-authored-by: rocketchat-github-ci <[email protected]> Co-authored-by: dionisio-bot[bot] <117394943+dionisio-bot[bot]@users.noreply.github.com> Co-authored-by: Pierre Lehnen <[email protected]> Co-authored-by: Kevin Aleman <[email protected]> Co-authored-by: gabriellsh <[email protected]> Co-authored-by: Julio A. <[email protected]> Co-authored-by: Guilherme Gazzo <[email protected]> Co-authored-by: Kevin Aleman <[email protected]> Co-authored-by: Ricardo Garim <[email protected]> Co-authored-by: Matheus Barbosa Silva <[email protected]> Co-authored-by: Tasso Evangelista <[email protected]> Co-authored-by: Martin Schoeler <[email protected]> Co-authored-by: Douglas Fabris <[email protected]> Co-authored-by: Júlia Jaeger Foresti <[email protected]> Co-authored-by: Guilherme Gazzo <[email protected]> Co-authored-by: Diego Sampaio <[email protected]> Co-authored-by: Hugo Costa <[email protected]> Co-authored-by: csuadev <[email protected]> Co-authored-by: Henrique Guimarães Ribeiro <[email protected]> Co-authored-by: Tasso Evangelista <[email protected]> Co-authored-by: Lucas Pelegrino <[email protected]> Co-authored-by: Trivikram Kamat <[email protected]>

…apped/composer-restriction * 'develop' of github.com:RocketChat/Rocket.Chat: (55 commits) regression: `Sidepanel` sort requires refresh after room update (#33370) ci: use node20 for release action (#33343) Bump rocket.chat to 6.14.0-develop (#33366) chore: replace Meteor._localStorage -> Accounts.storageLocation (#33356) Release 6.13.0-rc.1 fix: Avoid destructuring `connectionData` when value is undefined (#33339) feat: Adds new admin feature preview setting management (#33212) regression: `Sidepanel` color highlight (#33342) chore: move common files to core-services (#33341) feat: Adds new admin feature preview setting management (#33212) chore: create network broker package (#33338) fix: imported fixes (#33330) feat: Implement proper accessbility for report user modal (#33294) chore: update E2EE setting text (#33226) Release 6.13.0-rc.0 fix: conference calls are shown as "not answered" after they end (#33179) fix: markdown inconsistency with bold and italics (#33157) feat: E2EE messages mentions (#32510) refactor: Reactions set/unset (#32994) ci: auto candidate releases (#33325) ...

KevLehman added 3 commits August 5, 2024 14:58

Refactor setReaction

6d47822

Change find with countDocuments and add tests

26d44f5

ts

b6bda01

lint

17ced60

KevLehman marked this pull request as ready for review August 6, 2024 21:25

KevLehman requested review from a team as code owners August 6, 2024 21:26

KevLehman added this to the 6.12 milestone Aug 7, 2024

KevLehman changed the title ~~refactor: setReaction and executeSetReaction functions~~ refactor: Reactions set/unset Aug 7, 2024

MarcosSpessatto requested changes Aug 8, 2024

View reviewed changes

KevLehman added 2 commits August 12, 2024 08:16

cr

1aa1cd5

lint

3cc2055

KevLehman requested a review from MarcosSpessatto August 13, 2024 20:31

KevLehman added stat: QA assured Means it has been tested and approved by a company insider and removed stat: QA assured Means it has been tested and approved by a company insider labels Aug 16, 2024

dionisio-bot bot added the stat: conflict label Sep 16, 2024

Update afterUnsetReaction.js

0349cf4

dionisio-bot bot removed the stat: conflict label Sep 16, 2024

KevLehman mentioned this pull request Sep 17, 2024

chore: Update typings on callbacks to accept less than a full room object #33305

Merged

KevLehman added 4 commits September 17, 2024 10:59

Update isTheLastMessage.ts

9d6077f

Update BeforeFederationActions.ts

b1d3b60

Update service.ts

c3629a0

Update IMessageService.ts

0a304be

KevLehman mentioned this pull request Sep 18, 2024

refactor: Remove old setreaction callbacks and use new after/before callbacks #33309

Merged

KevLehman added 4 commits September 18, 2024 08:48

Discard changes to apps/meteor/app/reactions/client/methods/setReacti…

9e502b1

…on.ts

Discard changes to apps/meteor/app/slackbridge/server/RocketAdapter.js

995e7c3

Discard changes to apps/meteor/lib/callbacks.ts

b318215

Merge branch 'develop' into refactor/set-reactions

263a8b8

KevLehman marked this pull request as ready for review September 18, 2024 18:05

KevLehman requested a review from MarcosSpessatto September 18, 2024 18:07

KevLehman added the stat: ready to merge PR tested and approved waiting for merge label Sep 18, 2024

MarcosSpessatto previously requested changes Sep 19, 2024

View reviewed changes

apps/meteor/app/reactions/server/setReaction.ts Outdated Show resolved Hide resolved

KevLehman added 4 commits September 19, 2024 12:10

Update setReaction.ts

0cf7b67

Update setReaction.ts

8784d7f

Update setReaction.ts

71cc1aa

Update setReaction.spec.ts

9a2fc13

sampaiodiego approved these changes Sep 19, 2024

View reviewed changes

Merge branch 'develop' into refactor/set-reactions

1accdaf

sampaiodiego merged commit 7faba77 into develop Sep 19, 2024
8 of 29 checks passed

sampaiodiego deleted the refactor/set-reactions branch September 19, 2024 23:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: Reactions set/unset #32994

refactor: Reactions set/unset #32994

KevLehman commented Aug 6, 2024 •

edited

Loading

dionisio-bot bot commented Aug 6, 2024 •

edited

Loading

changeset-bot bot commented Aug 6, 2024 •

edited

Loading

codecov bot commented Aug 6, 2024 •

edited

Loading

github-actions bot commented Sep 17, 2024 •

edited

Loading

refactor: Reactions set/unset #32994

refactor: Reactions set/unset #32994

Conversation

KevLehman commented Aug 6, 2024 • edited Loading

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

dionisio-bot bot commented Aug 6, 2024 • edited Loading

changeset-bot bot commented Aug 6, 2024 • edited Loading

⚠️ No Changeset found

codecov bot commented Aug 6, 2024 • edited Loading

Codecov Report

github-actions bot commented Sep 17, 2024 • edited Loading

KevLehman commented Aug 6, 2024 •

edited

Loading

dionisio-bot bot commented Aug 6, 2024 •

edited

Loading

changeset-bot bot commented Aug 6, 2024 •

edited

Loading

codecov bot commented Aug 6, 2024 •

edited

Loading

github-actions bot commented Sep 17, 2024 •

edited

Loading