fix: resolve avatar download issue on setUsername by refining service selection logic

[ricardogarim]

As per CORE-650, this pull request addresses the issue where the avatar blob image was not being correctly set in the setUserAvatar method, resulting in an undefined error for the user. The root cause was identified as incorrect handling of avatar service selection, which led to errors during the avatar setting process.

Key changes:

• Corrected the service handling logic to ensure the avatar blob is properly set from the first available service.
• Enhanced the process to prioritize non-gravatar services while maintaining a fallback to gravatar if no other service is available.

[dionisio-bot]

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

[changeset-bot]

🦋 Changeset detected

Latest commit: 7a5bb19

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 28 packages

Name	Type
@rocket.chat/meteor	Patch
@rocket.chat/core-typings	Patch
@rocket.chat/rest-typings	Patch
@rocket.chat/api-client	Patch
@rocket.chat/apps	Patch
@rocket.chat/core-services	Patch
@rocket.chat/cron	Patch
@rocket.chat/ddp-client	Patch
@rocket.chat/fuselage-ui-kit	Patch
@rocket.chat/gazzodown	Patch
@rocket.chat/livechat	Patch
@rocket.chat/model-typings	Patch
@rocket.chat/ui-contexts	Patch
@rocket.chat/account-service	Patch
@rocket.chat/authorization-service	Patch
@rocket.chat/ddp-streamer	Patch
@rocket.chat/omnichannel-transcript	Patch
@rocket.chat/presence-service	Patch
@rocket.chat/queue-worker	Patch
@rocket.chat/stream-hub-service	Patch
@rocket.chat/license	Patch
@rocket.chat/omnichannel-services	Patch
@rocket.chat/pdf-worker	Patch
@rocket.chat/presence	Patch
rocketchat-services	Patch
@rocket.chat/uikit-playground	Patch
@rocket.chat/models	Patch
@rocket.chat/instance-status	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[codecov]

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 59.74%. Comparing base (f27092b) to head (7a5bb19).
Report is 1 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #33193      +/-   ##
===========================================
+ Coverage    59.70%   59.74%   +0.03%     
===========================================
  Files         2551     2552       +1     
  Lines        62792    62906     +114     
  Branches     14102    14129      +27     
===========================================
+ Hits         37492    37581      +89     
- Misses       22893    22917      +24     
- Partials      2407     2408       +1     

Flag	Coverage Δ
unit	76.96% <85.71%> (+0.05%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

[MarcosSpessatto]

Is there any way we could add some tests here?

[github-actions]

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-09-17 20:56 UTC

[sampaiodiego]

for a further optimization, when calling setUsername we don't need to call getAvatarSuggestionForUser which will fetch avatar for EVERY SERVICE available, we just need the first one =)