Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rust ffi asymmetric bumper support #788 #792

Merged
merged 3 commits into from
Sep 30, 2024
Merged

Add rust ffi asymmetric bumper support #788 #792

merged 3 commits into from
Sep 30, 2024

Conversation

shueja
Copy link
Collaborator

@shueja shueja commented Sep 30, 2024

Closes #788
No spec breakage.

calcmogul
calcmogul requested changes Sep 30, 2024
View reviewed changes
Copy link
Member

@calcmogul calcmogul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you add a SetBumpers() method to C++, you can simplify the Rust wrapper to just call that. The C++ API is a bit overly complex (see #791).

calcmogul
calcmogul requested changes Sep 30, 2024
View reviewed changes
trajoptlib/src/RustFFI.cpp Outdated Show resolved Hide resolved
@shueja shueja enabled auto-merge (squash) September 30, 2024 22:45
@shueja shueja merged commit 763826c into SleipnirGroup:main Sep 30, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calcmogul calcmogul calcmogul approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[trajoptlib] Bumper setter does not support asymmetry in either direction
2 participants
@shueja @calcmogul