-
Notifications
You must be signed in to change notification settings - Fork 780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend @on
decorator to filter matchable attributes
#2498
Merged
Merged
Changes from 25 commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
4a57e14
Add tests for #2484.
rodrigogiraoserrao 83b0ae7
Implement @on extension.
rodrigogiraoserrao 2898b1d
Changelog.
rodrigogiraoserrao e77b366
Add missing @on test.
rodrigogiraoserrao e097d64
Merge branch 'main' into on-kwargs
rodrigogiraoserrao 8febe0f
Remove debug prints.
rodrigogiraoserrao 0950e51
Document changes.
rodrigogiraoserrao 6434149
Merge branch 'main' into on-kwargs
rodrigogiraoserrao 938fa3b
Merge branch 'main' into on-kwargs
rodrigogiraoserrao 51139c4
Update tests.
rodrigogiraoserrao bd34558
Cache parsed selectors.
rodrigogiraoserrao 4f6ca0e
Streamline exit condition.
rodrigogiraoserrao 3adf63c
Fix typing.
rodrigogiraoserrao f1d6652
More succint wording.
rodrigogiraoserrao 0abb99f
Document 'on' kwargs.
rodrigogiraoserrao 64f1253
Update src/textual/_on.py
rodrigogiraoserrao 6b08b3c
Update docs/guide/events.md
rodrigogiraoserrao a7cc55e
Change 'on' API.
rodrigogiraoserrao 813a91a
Remove example code.
rodrigogiraoserrao 36ee21f
Address feedback.
rodrigogiraoserrao 63f2853
Update src/textual/_on.py
rodrigogiraoserrao 3842911
Address review feedback.
rodrigogiraoserrao 054b1c1
Merge branch 'main' into on-kwargs
rodrigogiraoserrao 5120f9e
Fix #2499.
rodrigogiraoserrao aa911e9
don't require control to be manually specified
willmcgugan 64f7fba
update docstring
willmcgugan 84ca784
deleted words
willmcgugan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@willmcgugan still trying to strike a balance between my personal verbose style and the intended style for the docs.
Let me know how this looks.